linux-kernel - Re: [PATCH net 1/7] net: hibmcge: fix incorrect pause frame statistics issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <816331a8-d6f9-4fb2-b9d7-3d51da303fe8@huawei.com>
Date: Thu, 3 Apr 2025 09:34:06 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Simon Horman <horms@...nel.org>
CC: <shaojijie@...wei.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <andrew+netdev@...n.ch>,
	<shenjian15@...wei.com>, <wangpeiyang1@...wei.com>, <liuyonglong@...wei.com>,
	<chenhao418@...wei.com>, <jonathan.cameron@...wei.com>,
	<shameerali.kolothum.thodi@...wei.com>, <salil.mehta@...wei.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net 1/7] net: hibmcge: fix incorrect pause frame
 statistics issue


on 2025/4/3 2:56, Simon Horman wrote:
> On Wed, Apr 02, 2025 at 09:38:59PM +0800, Jijie Shao wrote:
>> The driver supports pause frames,
>> but does not pass pause frames based on rx pause enable configuration,
>> resulting in incorrect pause frame statistics.
> I think it would be worth explaining why pause frames need
> to be passed through in order for statistics to be correct.
> I.e. which entity is passing them through to which other
> entity that counts them.

Yeah，This is the behavior of the MAC controller.
I'll describe it in v2

Thank you.
Jijie Shao

>
>> This patch fixes this problem.
>>
>> Fixes: 3a03763f3876 ("net: hibmcge: Add pauseparam supported in this module")
>> Signed-off-by: Jijie Shao <shaojijie@...wei.com>
> ...
>