linux-kernel - Re: [PATCH] mtd: spinand: Fix build with gcc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250403125252.03432904@endymion>
Date: Thu, 3 Apr 2025 12:52:52 +0200
From: Jean Delvare <jdelvare@...e.de>
To: Miquel Raynal <miquel.raynal@...tlin.com>
Cc: Richard Weinberger <richard@....at>, Vignesh Raghavendra
 <vigneshr@...com>, Tudor Ambarus <tudor.ambarus@...aro.org>, Pratyush Yadav
 <pratyush@...nel.org>, Michael Walle <michael@...le.cc>,
 <linux-mtd@...ts.infradead.org>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>, <linux-kernel@...r.kernel.org>, Steam Lin
 <stlin2@...bond.com>, kernel test robot <lkp@...el.com>,
 stable@...r.kernel.org
Subject: Re: [PATCH] mtd: spinand: Fix build with gcc < 7.5

On Tue,  1 Apr 2025 15:36:37 +0200, Miquel Raynal wrote:
> __VA_OPT__ is a macro that is useful when some arguments can be present
> or not to entirely skip some part of a definition. Unfortunately, it
> is a too recent addition that some of the still supported old GCC
> versions do not know about, and is anyway not part of C11 that is the
> version used in the kernel.
> 
> Find a trick to remove this macro, typically '__VA_ARGS__ + 0' is a
> workaround used in netlink.h which works very well here, as we either
> expect:
> - 0
> - A positive value
> - No value, which means the field should be 0.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202503181330.YcDXGy7F-lkp@intel.com/
> Fixes: 7ce0d16d5802 ("mtd: spinand: Add an optional frequency to read from cache macros")
> Cc: stable@...r.kernel.org
> Signed-off-by: Miquel Raynal <miquel.raynal@...tlin.com>

Tested-by: Jean Delvare <jdelvare@...e.de>

Thanks Miquel!

-- 
Jean Delvare
SUSE L3 Support