linux-kernel - Re: [PATCH v3 2/2] regulator: adp5055: Add driver for adp5055

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <360c60a4-d1ba-47bf-b65d-c6889801703f@sirena.org.uk>
Date: Thu, 3 Apr 2025 12:08:49 +0100
From: Mark Brown <broonie@...nel.org>
To: Alexis Czezar Torreno <alexisczezar.torreno@...log.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH v3 2/2] regulator: adp5055: Add driver for adp5055

On Thu, Apr 03, 2025 at 10:43:11AM +0800, Alexis Czezar Torreno wrote:

> +static int adp5055_is_enabled(struct regulator_dev *rdev)
> +{
> +	struct adp5055 *adp5055 = rdev_get_drvdata(rdev);
> +	int id = rdev_get_id(rdev);
> +	int val;
> +
> +	if (adp5055->en_mode_software)
> +		return regulator_is_enabled_regmap(rdev);
> +
> +	val = gpiod_get_value_cansleep(adp5055->en_gpiod[id]);
> +
> +	return val;
> +};

This is absolutely standard enable GPIO support, just let the core
handle everything.  Otherwise this looks fine.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)