linux-kernel - Re: [PATCH] crypto: inside-secure/eip93 - acquire lock on eip93_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z-5szPllytn7hQ03@gondor.apana.org.au>
Date: Thu, 3 Apr 2025 19:11:08 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Antoine Tenart <atenart@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Richard van Schagen <vschagen@...oud.com>,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] crypto: inside-secure/eip93 - acquire lock on
 eip93_put_descriptor hash

On Tue, Apr 01, 2025 at 01:57:30PM +0200, Christian Marangi wrote:
> In the EIP93 HASH functions, the eip93_put_descriptor is called without
> acquiring lock. This is problematic when multiple thread execute hash
> operations.
> 
> Correctly acquire ring write lock on calling eip93_put_descriptor to
> prevent concurrent access and mess with the ring pointers.
> 
> Cc: stable@...r.kernel.org
> Fixes: 9739f5f93b78 ("crypto: eip93 - Add Inside Secure SafeXcel EIP-93 crypto engine support")
> Reported-by: Herbert Xu <herbert@...dor.apana.org.au>
> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> ---
>  drivers/crypto/inside-secure/eip93/eip93-hash.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt