linux-kernel - Re: [RFC PATCH 1/3] i2c: core: Follow i2c-parent when retrieving an adapter from node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z-5u5bAnY8Y1DmFz@shikoro>
Date: Thu, 3 Apr 2025 13:20:05 +0200
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Herve Codina <herve.codina@...tlin.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-i2c@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Luca Ceresoli <luca.ceresoli@...tlin.com>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [RFC PATCH 1/3] i2c: core: Follow i2c-parent when retrieving an
 adapter from node


> The debug message can be interesting when things went wrong and we want
> to investigate potential issue with i2c-parent chain from the last device
> up to the adapter.

I thought so but couldn't estimate how often this is useful in reality.
I agree that introducing 'dev' is too much hazzle, yet I think the
message should have some id to disitnguish potential different adapter
chains. Either that, or...

> I don't have a strong opinion about the need of this message and I can
> simply remove it.

... we just remove it and let people add their debug stuff while
developing.

> What is your preference ?

A tad more 'removing'.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)