linux-kernel - Re: [PATCH net v3] ipv6: sit: fix skb_under_panic with overflowed needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe13ece8-67ea-48c0-a155-0cb6d2bcfc52@redhat.com>
Date: Thu, 3 Apr 2025 13:50:33 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Wang Liang <wangliang74@...wei.com>, davem@...emloft.net,
 dsahern@...nel.org, edumazet@...gle.com, kuba@...nel.org, horms@...nel.org,
 kuniyu@...zon.com
Cc: yuehaibing@...wei.com, zhangchangzhong@...wei.com,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v3] ipv6: sit: fix skb_under_panic with overflowed
 needed_headroom

On 4/1/25 4:16 AM, Wang Liang wrote:
> @@ -1452,7 +1457,9 @@ static int ipip6_tunnel_init(struct net_device *dev)
>  	tunnel->dev = dev;
>  	strcpy(tunnel->parms.name, dev->name);
>  
> -	ipip6_tunnel_bind_dev(dev);
> +	err = ipip6_tunnel_bind_dev(dev);
> +	if (err)
> +		return err;
>  
>  	err = dst_cache_init(&tunnel->dst_cache, GFP_KERNEL);
>  	if (err)

I think you additionally need to propagate the error in
ipip6_tunnel_update() and handle it in ipip6_changelink() and
ipip6_tunnel_change().

Side note: possibly other virtual devices are prone to similar issue. I
suspect vxlan and gre. Could you please have a look?

Thanks,

Paolo