linux-kernel - Re: [PATCH] asus-laptop: Fix an uninitialized variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250403122323.18129-1-arefev@swemel.ru>
Date: Thu,  3 Apr 2025 15:23:23 +0300
From: Denis Arefev <arefev@...mel.ru>
To: ilpo.jarvinen@...ux.intel.com
Cc: arefev@...mel.ru,
	corentin.chary@...il.com,
	hdegoede@...hat.com,
	linux-kernel@...r.kernel.org,
	luke@...nes.dev,
	lvc-project@...uxtesting.org,
	platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH] asus-laptop: Fix an uninitialized variable

> But if ACPI doesn't provide a value, why should that clamp value be used 
> instead? I'd tend to think curr would be more suitable "default".
> But shouldn't the loop either use continue to retry or the function 
> return curr right away if acpi_evaluate_integer() returns an error?

Hi Ilpo.

I'm sorry it took me so long to respond.

Yes, your comments are correct.
I hope the new patch will help to make the algorithm less noisy.

Regards Denis.