linux-kernel - Re: [PATCH -tip v3] x86/idle: Use MONITOR and MWAIT mnemonics in <asm/mwait.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250403125523.GHZ-6FO2mNZcUta1RG@fat_crate.local>
Date: Thu, 3 Apr 2025 14:55:23 +0200
From: Borislav Petkov <bp@...en8.de>
To: Uros Bizjak <ubizjak@...il.com>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...nel.org>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH -tip v3] x86/idle: Use MONITOR and MWAIT mnemonics in
 <asm/mwait.h>

On Thu, Apr 03, 2025 at 02:50:45PM +0200, Uros Bizjak wrote:
>  static __always_inline void __monitor(const void *eax, u32 ecx, u32 edx)
>  {
> -	/* "monitor %eax, %ecx, %edx;" */
> -	asm volatile(".byte 0x0f, 0x01, 0xc8;"
> -		     :: "a" (eax), "c" (ecx), "d"(edx));
> +	/* Use the instruction mnemonic with implicit operands, as the LLVM
> +	   assembler fails to assemble the mnemonic with explicit operands. */

mingo, pls fix up that comment style and in the other spot when applying.

Other than that:

Acked-by: Borislav Petkov (AMD) <bp@...en8.de>

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette