linux-kernel - Re: [PATCH v6 04/10] genirq: Introduce common irq_force_complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <667d272f-2b51-49d6-84ea-1156027e00a7@web.de>
Date: Thu, 3 Apr 2025 15:13:17 +0200
From: Frank Scheiner <frank.scheiner@....de>
To: apatel@...tanamicro.com
Cc: ajones@...tanamicro.com, andrew@...n.ch, anup@...infault.org,
 atishp@...shpatra.org, bp@...en8.de, dave.hansen@...ux.intel.com,
 gregory.clement@...tlin.com, hpa@...or.com, imx@...ts.linux.dev,
 kernel@...gutronix.de, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
 maz@...nel.org, mingo@...hat.com, palmer@...belt.com,
 paul.walmsley@...ive.com, s.hauer@...gutronix.de,
 sebastian.hesselbarth@...il.com, shawnguo@...nel.org,
 sunilvl@...tanamicro.com, tglx@...utronix.de, x86@...nel.org,
 linux-ia64@...r.kernel.org
Subject: Re: [PATCH v6 04/10] genirq: Introduce common
 irq_force_complete_move() implementation

Hi there,

this change, specfically the introduction of irq_force_complete_move()
to `kernel/irq/migration.c`, strangely breaks our builds for the hp-sim
platform (i.e. Linux/ia64 for Ski):

```
  CC      kernel/irq/affinity.o
kernel/irq/migration.c: In function 'irq_force_complete_move':
kernel/irq/migration.c:40:72: error: 'struct irq_data' has no member named 'parent_data'
   40 |         for (struct irq_data *d = irq_desc_get_irq_data(desc); d; d = d->parent_data) {
      |                                                                        ^~
make[4]: *** [scripts/Makefile.build:207: kernel/irq/migration.o] Error 1
```

The reason seems to be that "d->parent_data" (i.e.
"irq_data.parent_data") is used unguarded in this function:

```
void irq_force_complete_move(struct irq_desc *desc)
{
    for (struct irq_data *d = irq_desc_get_irq_data(desc); d; d = d->parent_data) {
        if (d->chip && d->chip->irq_force_complete_move) {
            d->chip->irq_force_complete_move(d);
            return;
        }
    }
}
```

...but "parent_data" is only present in `include/linux/irq.h` if
`CONFIG_IRQ_DOMAIN_HIERARCHY` was selected.

```
struct irq_data {
    u32            mask;
    unsigned int        irq;
    irq_hw_number_t        hwirq;
    struct irq_common_data    *common;
    struct irq_chip        *chip;
    struct irq_domain    *domain;
#ifdef    CONFIG_IRQ_DOMAIN_HIERARCHY
    struct irq_data        *parent_data;
#endif
    void            *chip_data;
};
```

So I guess, either the requirement in `linux/include/linux/irq.h` needs
to go, or the use of "d->parent_data" or the whole of
irq_force_complete_move() and its use needs to be guarded as well.

Cheers,
Frank