linux-kernel - Re: [PATCH v2] drm/nouveau: Prevent signalled fences in pending list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z-6J7bngU2JtfMMN@pollux>
Date: Thu, 3 Apr 2025 15:15:25 +0200
From: Danilo Krummrich <dakr@...nel.org>
To: phasta@...nel.org
Cc: Christian König <christian.koenig@....com>,
	Lyude Paul <lyude@...hat.com>, David Airlie <airlied@...il.com>,
	Simona Vetter <simona@...ll.ch>,
	Sumit Semwal <sumit.semwal@...aro.org>,
	dri-devel@...ts.freedesktop.org, nouveau@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
	linaro-mm-sig@...ts.linaro.org, stable@...r.kernel.org
Subject: Re: [PATCH v2] drm/nouveau: Prevent signalled fences in pending list

On Thu, Apr 03, 2025 at 02:58:13PM +0200, Philipp Stanner wrote:
> On Thu, 2025-04-03 at 14:08 +0200, Christian König wrote:
> > Am 03.04.25 um 12:13 schrieb Philipp Stanner:
> 
> > BTW: nouveau_fence_no_signaling() looks completely broken as well. It
> > calls nouveau_fence_is_signaled() and then list_del() on the fence
> > head.
> 
> I can assure you that a great many things in Nouveau look completely
> broken.
> 
> The question for us is always the cost-benefit-ratio when fixing bugs.
> There are fixes that solve the bug with reasonable effort, and there
> are great reworks towards an ideal state.

That's just an additional thing that Christian noticed. It isn't really directly
related to what you want to fix with your patch.

I think the function can simply be dropped.