linux-kernel - RE: [PATCH] HID: intel-thc-hid: intel-thc: make read-only arrays static const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR11MB60980AFB37E42D8EB7085D27F4AE2@IA1PR11MB6098.namprd11.prod.outlook.com>
Date: Thu, 3 Apr 2025 01:12:35 +0000
From: "Xu, Even" <even.xu@...el.com>
To: Colin Ian King <colin.i.king@...il.com>, "Sun, Xinpeng"
	<xinpeng.sun@...el.com>, Jiri Kosina <jikos@...nel.org>, Benjamin Tissoires
	<bentiss@...nel.org>, Srinivas Pandruvada
	<srinivas.pandruvada@...ux.intel.com>, Mark Pearson
	<mpearson-lenovo@...ebb.ca>, "linux-input@...r.kernel.org"
	<linux-input@...r.kernel.org>
CC: "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] HID: intel-thc-hid: intel-thc: make read-only arrays
 static const



> -----Original Message-----
> From: Colin Ian King <colin.i.king@...il.com>
> Sent: Wednesday, April 2, 2025 7:21 PM
> To: Xu, Even <even.xu@...el.com>; Sun, Xinpeng <xinpeng.sun@...el.com>; Jiri
> Kosina <jikos@...nel.org>; Benjamin Tissoires <bentiss@...nel.org>; Srinivas
> Pandruvada <srinivas.pandruvada@...ux.intel.com>; Mark Pearson <mpearson-
> lenovo@...ebb.ca>; linux-input@...r.kernel.org
> Cc: kernel-janitors@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] HID: intel-thc-hid: intel-thc: make read-only arrays static const
> 
> Don't populate the read-only arrays frequency and frequency_div on the stack at
> run time, instead make them static const.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>  drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c b/drivers/hid/intel-
> thc-hid/intel-thc/intel-thc-dev.c
> index 4fc78b5a04b5..c105df7f6c87 100644
> --- a/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c
> +++ b/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c
> @@ -1121,7 +1121,7 @@ EXPORT_SYMBOL_NS_GPL(thc_port_select,
> "INTEL_THC");
> 
>  static u8 thc_get_spi_freq_div_val(struct thc_device *dev, u32 spi_freq_val)  {
> -	int frequency[] = {
> +	static const int frequency[] = {
>  		THC_SPI_FREQUENCY_7M,
>  		THC_SPI_FREQUENCY_15M,
>  		THC_SPI_FREQUENCY_17M,
> @@ -1130,7 +1130,7 @@ static u8 thc_get_spi_freq_div_val(struct thc_device
> *dev, u32 spi_freq_val)
>  		THC_SPI_FREQUENCY_31M,
>  		THC_SPI_FREQUENCY_41M,
>  	};
> -	u8 frequency_div[] = {
> +	static const u8 frequency_div[] = {
>  		THC_SPI_FRQ_DIV_2,
>  		THC_SPI_FRQ_DIV_1,
>  		THC_SPI_FRQ_DIV_7,

Thanks for the improvement!
LGTM.
Reviewed-by: Even Xu <even.xu@...el.com>

> --
> 2.49.0