linux-kernel - Re: [PATCH] test suite: Use %zu to print size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ubvc2fxn6zl6g6kb5ndzazyjj6ds54onawxvar5j5vfu6gz2dy@k2mfcvhatoza>
Date: Wed, 2 Apr 2025 22:53:52 -0400
From: "Liam R. Howlett" <Liam.Howlett@...cle.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: maple-tree@...ts.infradead.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>
Subject: Re: [PATCH] test suite: Use %zu to print size_t

* Liam R. Howlett <Liam.Howlett@...cle.com> [250402 20:33]:
> From: "Matthew Wilcox (Oracle)" <willy@...radead.org>
> 
> On 32-bit, we can't use %lu to print a size_t variable and gcc warns us
> about it.  Shame it doesn't warn about it on 64-bit.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@...radead.org>
> Fixes: cc86e0c2f306 (radix tree test suite: add support for slab bulk APIs)
> Signed-off-by: Liam R. Howlett <Liam.Howlett@...cle.com>
> ---
> 
> Note that this requires the patch to fix the headers [1] for the testing
> to build.  Unfortunately, that has not landed, but the patches do not
> conflict so we should push this upstream anyways.
> 
> [1].  https://lore.kernel.org/all/20250321-fix-radix-tree-build-v1-1-838a1e6540e2@samsung.com/

Sorry, This should not have been 'in-reply-to' the previous older patch
set.  Let me know if you want me to resend.

Thanks,
Liam

> 
>  tools/testing/shared/linux.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/shared/linux.c b/tools/testing/shared/linux.c
> index 66dbb362385f3..0f97fb0d19e19 100644
> --- a/tools/testing/shared/linux.c
> +++ b/tools/testing/shared/linux.c
> @@ -150,7 +150,7 @@ void kmem_cache_free(struct kmem_cache *cachep, void *objp)
>  void kmem_cache_free_bulk(struct kmem_cache *cachep, size_t size, void **list)
>  {
>  	if (kmalloc_verbose)
> -		pr_debug("Bulk free %p[0-%lu]\n", list, size - 1);
> +		pr_debug("Bulk free %p[0-%zu]\n", list, size - 1);
>  
>  	pthread_mutex_lock(&cachep->lock);
>  	for (int i = 0; i < size; i++)
> @@ -168,7 +168,7 @@ int kmem_cache_alloc_bulk(struct kmem_cache *cachep, gfp_t gfp, size_t size,
>  	size_t i;
>  
>  	if (kmalloc_verbose)
> -		pr_debug("Bulk alloc %lu\n", size);
> +		pr_debug("Bulk alloc %zu\n", size);
>  
>  	pthread_mutex_lock(&cachep->lock);
>  	if (cachep->nr_objs >= size) {
> -- 
> 2.43.0
>