linux-kernel - Re: [PATCH] staging: octeon: Fix unused macro Argument 'x'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025040315-squid-gloating-e0df@gregkh>
Date: Thu, 3 Apr 2025 15:09:36 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: nancyenos <nicymimz@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
	outreachy@...ts.linux.dev
Subject: Re: [PATCH] staging: octeon: Fix unused macro Argument 'x'

On Tue, Mar 25, 2025 at 03:09:52AM -0700, nancyenos wrote:
> warning found by checkpath.pl
> 
> Signed-off-by: nancyenos <nicymimz@...il.com>
> ---
>  drivers/staging/octeon/octeon-stubs.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
> index 44cced319c11..0155f3c41657 100644
> --- a/drivers/staging/octeon/octeon-stubs.h
> +++ b/drivers/staging/octeon/octeon-stubs.h
> @@ -8,8 +8,8 @@
>  #define OCTEON_IRQ_WORKQ0 0
>  #define OCTEON_IRQ_RML 0
>  #define OCTEON_IRQ_TIMER1 0
> -#define OCTEON_IS_MODEL(x) 0
> -#define octeon_has_feature(x)	0
> +#define OCTEON_IS_MODEL(x) ((void)(x), 0)
> +#define octeon_has_feature(x) ((void)(x), 0)
>  #define octeon_get_clock_rate()	0
>  
>  #define CVMX_SYNCIOBDMA		do { } while (0)
> -- 
> 2.25.1
> 
> 

You sent this twice?

And always test-build your patches before submitting them.  This
obviously will not build :(

thanks,

greg k-h