linux-kernel - Re: [PATCH] staging: sm750fb: modify function name to kernel code style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025040301-tightness-giveaway-a568@gregkh>
Date: Thu, 3 Apr 2025 15:16:47 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Richard Akintola <princerichard17a@...il.com>
Cc: sudipm.mukherjee@...il.com, teddy.wang@...iconmotion.com,
	linux-fbdev@...r.kernel.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org, julia.lawall@...ia.fr
Subject: Re: [PATCH] staging: sm750fb: modify function name to kernel code
 style

On Mon, Mar 31, 2025 at 09:53:36AM +0100, Richard Akintola wrote:
> Change camelCase function name sii164ResetChip to sii164_reset_chip
> as reported by checkpatch.pl
> 
> CHECK: Avoid camelCase: <sii164ResetChip>
> 
> Signed-off-by: Richard Akintola <princerichard17a@...il.com>
> ---
>  drivers/staging/sm750fb/ddk750_dvi.c    | 2 +-
>  drivers/staging/sm750fb/ddk750_sii164.c | 4 ++--
>  drivers/staging/sm750fb/ddk750_sii164.h | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)

You sent 2 different patches with different subject lines, yet they
almost did the same thing?  Which one should I take or review?  Please
send a new one, as a version 3, and properly document what changed
between this one and the last 2 submissions.

thanks,

greg k-h