linux-kernel - Re: [PATCH v9 3/4] arm64: defconfig: add S32G RTC module support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dfc1c195-4514-4667-b9b5-96ab3e175bd0@oss.nxp.com>
Date: Fri, 4 Apr 2025 14:36:30 +0300
From: Ciprian Marian Costea <ciprianmarian.costea@....nxp.com>
To: Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Catalin Marinas <catalin.marinas@....com>,
 Will Deacon <will@...nel.org>, linux-rtc@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, NXP S32 Linux <s32@....com>,
 imx@...ts.linux.dev, Christophe Lizzi <clizzi@...hat.com>,
 Alberto Ruiz <aruizrui@...hat.com>, Enric Balletbo <eballetb@...hat.com>,
 Eric Chanudet <echanude@...hat.com>
Subject: Re: [PATCH v9 3/4] arm64: defconfig: add S32G RTC module support

On 4/4/2025 11:53 AM, Alexandre Belloni wrote:
> On 04/04/2025 10:19:56+0300, Ciprian Marian Costea wrote:
>> On 4/4/2025 10:15 AM, Krzysztof Kozlowski wrote:
>>> On 04/04/2025 08:24, Ciprian Marian Costea wrote:
>>>> On 4/4/2025 9:17 AM, Krzysztof Kozlowski wrote:
>>>>> On 03/04/2025 12:33, Ciprian Costea wrote:
>>>>>> From: Ciprian Marian Costea <ciprianmarian.costea@....nxp.com>
>>>>>>
>>>>>> The RTC hardware module present on S32G based SoCs tracks clock time
>>>>>> during system suspend and it is used as a wakeup source on S32G2/S32G3
>>>>>> architecture.
>>>>> Which boards are using it? I don't see any DTS (nowhere), so I do not
>>>>> see single reason for this patch.
>>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>>
>>>> The RTC module is used by all the currently supported S32G2/S32G3
>>>> boards, so currently they are: S32G274A-EVB, S32G274A-RDB2, S32G399A-RDB3.
>>>
>>> I don't think so. I looked at these DTS and there is no RTC.
>>>
>>>> I do see your point in the fact that this driver should be enabled as
>>>> module only after platforms are actually using it.
>>>
>>> No, post the user. I don't see the point of sending defconfig patch with
>>> RTC patchset anyway. That's different subsystem.
>>>
>>>>
>>>> So, would it be better for me to send a V10 in this series with the DTS
>>>> patch added ?
>>>
>>> No, separate patchsets.
>>
>> Ok. I will send out a V10 in which I will drop this current patch from the
>> patchset. Also, I will send the DTS patch which adds S32G274A-EVB,
>> S32G274-RDB2 and S32G399A-RDB3 usage of the RTC after this patchset gets
>> accepted.
>>
> 
> I don't need V10, I can apply V9 without 3/4 and 4/4
> 

Ok. Thanks for letting me know.

Ciprian

>> Best Regards,
>> Ciprian
>>
>>>
>>> Best regards,
>>> Krzysztof
>>
>