linux-kernel - Re: [PATCH v3 03/10] dt-bindings: display: msm: document DSI controller and phy on SA8775P

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5cfdb91e-54d3-4871-a09c-5ece37099b6a@kernel.org>
Date: Sat, 5 Apr 2025 09:48:47 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ayushi Makhija <quic_amakhija@...cinc.com>,
 linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 freedreno@...ts.freedesktop.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: robdclark@...il.com, dmitry.baryshkov@...aro.org, sean@...rly.run,
 marijn.suijten@...ainline.org, andersson@...nel.org, robh@...nel.org,
 robh+dt@...nel.org, krzk+dt@...nel.org, konradybcio@...nel.org,
 conor+dt@...nel.org, andrzej.hajda@...el.com, neil.armstrong@...aro.org,
 rfoss@...nel.org, Laurent.pinchart@...asonboard.com, jonas@...boo.se,
 jernej.skrabec@...il.com, quic_abhinavk@...cinc.com,
 quic_rajeevny@...cinc.com, quic_vproddut@...cinc.com,
 quic_jesszhan@...cinc.com
Subject: Re: [PATCH v3 03/10] dt-bindings: display: msm: document DSI
 controller and phy on SA8775P

On 04/04/2025 13:55, Ayushi Makhija wrote:
> Document DSI controller and phy on SA8775P platform.
> 
> Signed-off-by: Ayushi Makhija <quic_amakhija@...cinc.com>
> ---
>  .../display/msm/qcom,sa8775p-mdss.yaml        | 183 +++++++++++++++++-
>  1 file changed, 182 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> index 5fac3e266703..1be26137b7b6 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml
> @@ -52,12 +52,25 @@ patternProperties:
>          items:
>            - const: qcom,sa8775p-dp
>  
> +  "^dsi@[0-9a-f]+$":
> +    type: object
> +    additionalProperties: true
> +    properties:
> +      compatible:
> +        contains:
> +          enum:

huh?

> +            - qcom,sa8775p-dsi-ctrl
> +            - qcom,mdss-dsi-ctrl

This makes no sense and I am pretty sure it breaks everything and was
not tested.

All previous comments apply.


Best regards,
Krzysztof