linux-kernel - Re: [v3 0/1] Unnecessary code cleanup patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69c335ea-dbeb-4c9-135e-2312a77e9ac6@inria.fr>
Date: Sat, 5 Apr 2025 04:49:43 -0400 (EDT)
From: Julia Lawall <julia.lawall@...ia.fr>
To: Greg KH <gregkh@...uxfoundation.org>
cc: Abraham Samuel Adekunle <abrahamadekunle50@...il.com>, 
    outreachy@...ts.linux.dev, julia.lawall@...ia.fr, 
    linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org, 
    andy@...nel.org
Subject: Re: [v3 0/1] Unnecessary code cleanup patches



On Sat, 5 Apr 2025, Greg KH wrote:

> On Fri, Apr 04, 2025 at 01:02:19AM +0100, Abraham Samuel Adekunle wrote:
> > The patchset modifies unnecessary duplicate NULL test on a
> > value in an expression, when the value has been NULL tested in a
> > previous expression.
>
> Nit, the subject line does nto have "staging:" in it, so I don't know
> where this goes.
>
> Also, it really reads as "this is an unnecessary patch" :)

Technically, in English, if you have a noun that is being used as an
adjective and that noun is itself modified in some way, you should use a
hyphen:

Unnecessary-code cleanup patches

But something like

Remove unnecessary code

would have had no ambiguity at all.  Also everything you are doing is a
patch, so "patches" in the subject line doesn't seem very necessary.

julia


>
> And finally, for a single patch, there's usually not a need for a 0/X
> email to describe it, everything should be in just the single patch
> itself.
>
> thanks,
>
> greg k-h
>
>