linux-kernel - Re: [PATCH] staging: rtl8723bs: Use % 4096 instead of & 0xfff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250405101318.3fce2dd5@pumpkin>
Date: Sat, 5 Apr 2025 10:13:18 +0100
From: David Laight <david.laight.linux@...il.com>
To: Abraham Samuel Adekunle <abrahamadekunle50@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Julia Lawall
 <julia.lawall@...ia.fr>, outreachy@...ts.linux.dev,
 linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org, Dan Carpenter
 <dan.carpenter@...aro.org>, "andy."@kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: Use % 4096 instead of & 0xfff

On Fri, 4 Apr 2025 23:33:16 +0000
Abraham Samuel Adekunle <abrahamadekunle50@...il.com> wrote:

> Replace the bitwise AND operator `&` with a modulo
> operator `%` and decimal number to make the upper limit visible
> and clear what the semantic of it is.

Use 4096u to make absolutely certain an unsigned module is used.

	David

> 
> Also add white spaces around binary operators for improved
> readabiity and adherence to Linux kernel coding style.
> 
> Suggested-by Andy Shevchenko <andy.shevchenko@...il.com>
> 
> Signed-off-by: Abraham Samuel Adekunle <abrahamadekunle50@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_xmit.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> index 297c93d65315..630669193be4 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> @@ -943,7 +943,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattr
>  
>  			if (psta) {
>  				psta->sta_xmitpriv.txseq_tid[pattrib->priority]++;
> -				psta->sta_xmitpriv.txseq_tid[pattrib->priority] &= 0xFFF;
> +				psta->sta_xmitpriv.txseq_tid[pattrib->priority] %= 4096;
>  				pattrib->seqnum = psta->sta_xmitpriv.txseq_tid[pattrib->priority];
>  
>  				SetSeqNum(hdr, pattrib->seqnum);
> @@ -963,11 +963,11 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattr
>  					if (SN_LESS(pattrib->seqnum, tx_seq)) {
>  						pattrib->ampdu_en = false;/* AGG BK */
>  					} else if (SN_EQUAL(pattrib->seqnum, tx_seq)) {
> -						psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (tx_seq+1)&0xfff;
> +						psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (tx_seq + 1) % 4096;
>  
>  						pattrib->ampdu_en = true;/* AGG EN */
>  					} else {
> -						psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (pattrib->seqnum+1)&0xfff;
> +						psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (pattrib->seqnum + 1) % 4096;
>  						pattrib->ampdu_en = true;/* AGG EN */
>  					}
>  				}