linux-kernel - Re: [PATCH 1/8] staging: sm750fb: change sii164GetDeviceID to snake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025040550-alkalize-unproven-b99d@gregkh>
Date: Sat, 5 Apr 2025 12:05:02 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Richard Akintola <princerichard17a@...il.com>
Cc: sudipm.mukherjee@...il.com, teddy.wang@...iconmotion.com,
	linux-fbdev@...r.kernel.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org, outreachy@...ts.linux.dev,
	julia.lawall@...ia.fr
Subject: Re: [PATCH 1/8] staging: sm750fb: change sii164GetDeviceID to
 snake_case

On Sat, Apr 05, 2025 at 11:13:58AM +0100, Richard Akintola wrote:
> Change camelCase function name sii164GetDeviceID to sii164_get_device_id
> to conform to kernel code styles as reported by checkpatch.pl
> 
> CHECK: Avoid camelCase: <sii164GetDeviceID>
> 
> Signed-off-by: Richard Akintola <princerichard17a@...il.com>
> ---
>  drivers/staging/sm750fb/ddk750_dvi.c    | 2 +-
>  drivers/staging/sm750fb/ddk750_sii164.c | 6 +++---
>  drivers/staging/sm750fb/ddk750_sii164.h | 2 +-
>  3 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
> index 8b81e8642f9e..3fb14eff2de1 100644
> --- a/drivers/staging/sm750fb/ddk750_dvi.c
> +++ b/drivers/staging/sm750fb/ddk750_dvi.c
> @@ -16,7 +16,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {
>  	{
>  		.init = sii164_init_chip,
>  		.get_vendor_id = sii164_get_vendor_id,
> -		.get_device_id = sii164GetDeviceID,
> +		.get_device_id = sii164_get_device_id,
>  #ifdef SII164_FULL_FUNCTIONS
>  		.reset_chip = sii164ResetChip,
>  		.get_chip_string = sii164GetChipString,
> diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
> index 2532b60245ac..223c181dc649 100644
> --- a/drivers/staging/sm750fb/ddk750_sii164.c
> +++ b/drivers/staging/sm750fb/ddk750_sii164.c
> @@ -48,13 +48,13 @@ unsigned short sii164_get_vendor_id(void)
>  }
>  
>  /*
> - *  sii164GetDeviceID
> + *  sii164_get_device_id
>   *      This function gets the device ID of the DVI controller chip.
>   *
>   *  Output:
>   *      Device ID
>   */
> -unsigned short sii164GetDeviceID(void)
> +unsigned short sii164_get_device_id(void)
>  {
>  	unsigned short deviceID;
>  
> @@ -141,7 +141,7 @@ long sii164_init_chip(unsigned char edge_select,
>  
>  	/* Check if SII164 Chip exists */
>  	if ((sii164_get_vendor_id() == SII164_VENDOR_ID) &&
> -	    (sii164GetDeviceID() == SII164_DEVICE_ID)) {
> +	    (sii164_get_device_id() == SII164_DEVICE_ID)) {
>  		/*
>  		 *  Initialize SII164 controller chip.
>  		 */
> diff --git a/drivers/staging/sm750fb/ddk750_sii164.h b/drivers/staging/sm750fb/ddk750_sii164.h
> index 71a7c1cb42c4..a76091f6622b 100644
> --- a/drivers/staging/sm750fb/ddk750_sii164.h
> +++ b/drivers/staging/sm750fb/ddk750_sii164.h
> @@ -28,7 +28,7 @@ long sii164_init_chip(unsigned char edgeSelect,
>  		      unsigned char pllFilterValue);
>  
>  unsigned short sii164_get_vendor_id(void);
> -unsigned short sii164GetDeviceID(void);
> +unsigned short sii164_get_device_id(void);
>  
>  #ifdef SII164_FULL_FUNCTIONS
>  void sii164ResetChip(void);
> -- 
> 2.39.5
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot