linux-kernel - Re: [PATCH v3 10/32] mfd: sec: merge separate core and irq modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <932d245b63abbcb96611715e8b234138087d84db.camel@linaro.org>
Date: Sat, 05 Apr 2025 14:45:40 +0100
From: André Draszik <andre.draszik@...aro.org>
To: Lee Jones <lee@...nel.org>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, Rob Herring <robh@...nel.org>, 
 Conor Dooley <conor+dt@...nel.org>, Sylwester Nawrocki
 <s.nawrocki@...sung.com>, Chanwoo Choi	 <cw00.choi@...sung.com>, Alim
 Akhtar <alim.akhtar@...sung.com>, Michael Turquette
 <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Russell King	
 <linux@...linux.org.uk>, Catalin Marinas <catalin.marinas@....com>, Will
 Deacon	 <will@...nel.org>, Alexandre Belloni
 <alexandre.belloni@...tlin.com>, Peter Griffin <peter.griffin@...aro.org>,
 Tudor Ambarus <tudor.ambarus@...aro.org>, Will McVicker	
 <willmcvicker@...gle.com>, kernel-team@...roid.com, 
	linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-clk@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-rtc@...r.kernel.org, Krzysztof
 Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v3 10/32] mfd: sec: merge separate core and irq modules

On Fri, 2025-04-04 at 10:21 +0100, Lee Jones wrote:
> On Thu, 03 Apr 2025, André Draszik wrote:
> 
> > There is no reason to have these two kernel modules separate. Having
> > them merged into one kernel module also slightly reduces memory
> > consumption and module load times a little.
> > 
> > mapped size (lsmod):
> >          before:             after:
> >     sec_core   20480    sec_core   24576
> >     sec_irq    16384
> >     ----------------
> >     total      36864
> > 
> > Section sizes (size -A):
> >          before:             after:
> >     sec_core    6780    sec_core   13239
> >     sec_irq     8046
> >     ----------------
> >     Total      14826
> > 
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > Signed-off-by: André Draszik <andre.draszik@...aro.org>
> > ---
> > Checkpatch suggests to update MAINTAINERS, but the new file is covered
> > already due to using a wildcard.
> > ---
> >  drivers/mfd/Makefile                     | 3 ++-
> >  drivers/mfd/{sec-core.c => sec-common.c} | 2 ++
> 
> Okay, but why the name change?

Because I wanted to keep sec-core.ko. But with kbuild, you can't generate
sec-core.ko from sec-core.c and additional files. Either just one file,
sec-core.c, or multiple files none of which may be called sec-core.c

> 
> >  drivers/mfd/sec-irq.c                    | 9 ---------
> >  3 files changed, 4 insertions(+), 10 deletions(-)
> > 
> > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> > index b617782eca436e34084a9cd24c309801c5680390..8f315298b32a2a9ee114ed5e49e760bd8f930aee 100644
> > --- a/drivers/mfd/Makefile
> > +++ b/drivers/mfd/Makefile
> > @@ -228,7 +228,8 @@ obj-$(CONFIG_MFD_RK8XX)		+= rk8xx-core.o
> >  obj-$(CONFIG_MFD_RK8XX_I2C)	+= rk8xx-i2c.o
> >  obj-$(CONFIG_MFD_RK8XX_SPI)	+= rk8xx-spi.o
> >  obj-$(CONFIG_MFD_RN5T618)	+= rn5t618.o
> > -obj-$(CONFIG_MFD_SEC_CORE)	+= sec-core.o sec-irq.o
> > +sec-core-objs			:= sec-common.o sec-irq.o
> > +obj-$(CONFIG_MFD_SEC_CORE)	+= sec-core.o

Unless I'm missing some trick.

Cheers,
Andre'