linux-kernel - Re: [PATCH 2/2] staging: rtl8723bs: Initialize local variables at declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aec43d5d-8f9f-4951-9ddb-03b66b1ce859@stanley.mountain>
Date: Sat, 5 Apr 2025 17:21:53 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Julia Lawall <julia.lawall@...ia.fr>
Cc: Greg KH <gregkh@...uxfoundation.org>,
	Erick Karanja <karanja99erick@...il.com>, outreachy@...ts.linux.dev,
	philipp.g.hortmann@...il.com, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] staging: rtl8723bs: Initialize local variables at
 declaration

On Sat, Apr 05, 2025 at 04:41:37AM -0400, Julia Lawall wrote:
> 
> I guess the first change above would be ok though.

Here is the first change:

-	struct xmit_priv *pxmitpriv;
+	struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
  	u8 queue_empty, queue_pending;
  	s32 ret;

-
-	pxmitpriv = &padapter->xmitpriv;
-

Yes.  This is a nice change.

regards,
dan carpenter