linux-kernel - Re: [PATCH v2] staging: rtl8723bs: Use % 4096 instead of & 0xfff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADYq+fYMPGFdFvNPyo_XoNdMhh6qu=h10Gb2EDc2Jw=JK9iXig@mail.gmail.com>
Date: Sat, 5 Apr 2025 15:55:18 +0100
From: Samuel Abraham <abrahamadekunle50@...il.com>
To: Julia Lawall <julia.lawall@...ia.fr>
Cc: Andy Shevchenko <andy.shevchenko@...il.com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, andy@...nel.org, dan.carpenter@...aro.org, 
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	outreachy@...ts.linux.dev
Subject: Re: [PATCH v2] staging: rtl8723bs: Use % 4096 instead of & 0xfff

On Sat, Apr 5, 2025 at 1:30 PM Julia Lawall <julia.lawall@...ia.fr> wrote:
>
>
>
> On Sat, 5 Apr 2025, Andy Shevchenko wrote:
>
> > On Sat, Apr 5, 2025 at 11:23 AM Greg Kroah-Hartman
> > <gregkh@...uxfoundation.org> wrote:
> > > On Sat, Apr 05, 2025 at 12:09:59AM +0000, Abraham Samuel Adekunle wrote:
> > > > Replace the bitwise AND operator `&` with a modulo
> > > > operator `%` and decimal number to make the upper limit visible
> > > > and clear what the semantic of it is.
> > >
> > > Eeek, no.  We all "know" what & means (it's a bit mask to handle the
> > > issues involved), and we all do NOT know that % will do the same thing
> > > at all.
> >
> > And that is exactly the purpose of the change. The % 4096 makes it
> > clearer on what's going on, i.e. we are doing indexes that are wrapped
> > around the given number.
>
> Ah, OK.  Samuel, indeed, the log message was going in that direction.  But
> probably it should be more clear.  Why is 4096 the upper limit in this
> case, for example.

Okay thank you Julia.
So I can add something like this to the commit message?

"Replace the bitwise AND operator `&` with a modulo
operator `%` and decimal number to make the upper limit visible
and clear that we are doing indexes that are wrapped around the given number"?

You also said I should add a patch for the white space around binary operators.
I did it together because the changes were on the same line.
Should I still add a second patch for that change?
Thanks

Adekunle.