[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250405215529.7f3f3253@akair>
Date: Sat, 5 Apr 2025 21:55:29 +0200
From: Andreas Kemnade <andreas@...nade.info>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Sukrut Bellary <sbellary@...libre.com>, Michael Turquette
<mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Rob Herring
<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Tero Kristo <kristo@...nel.org>, Kevin Hilman
<khilman@...libre.com>, linux-clk@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: clock: ti: Convert to yaml
Am Fri, 4 Apr 2025 12:44:39 +0200
schrieb Krzysztof Kozlowski <krzk@...nel.org>:
> On Thu, Apr 03, 2025 at 06:44:57PM GMT, Sukrut Bellary wrote:
> > +properties:
> > + reg:
> > + maxItems: 1
>
> How reg is part of this? Every clock has reg, doesn't it? Otherwise how
> do you control it? Drop.
>
> > +
> > + ti,autoidle-shift:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + description:
> > + bit shift of the autoidle enable bit for the clock
> > + maximum: 31
> > + default: 0
> > +
> > + ti,invert-autoidle-bit:
> > + type: boolean
> > + description:
> > + autoidle is enabled by setting the bit to 0
>
> required:
> - ti,autoidle-shift
> - ti,invert-autoidle-bit - although this makes no sense, so probably
> old binding was not correct here
>
well, the more informal definition in the txt file can be read as: if
the clock supports autoidle, then ti,autoidle-shift is required. But
that does not
translate to the formal definition in the yaml file.
So we have nothing required here.
I am a bit wondering whether we should just drop the autoidle.txt. The
only thing worth there is the description.
Regards,
Andreas
Powered by blists - more mailing lists