linux-kernel - Re: [PATCH] iwlwifi: mld: fix building with CONFIG_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z_KHkknIxQWzXhry@wunner.de>
Date: Sun, 6 Apr 2025 15:54:26 +0200
From: Lukas Wunner <lukas@...ner.de>
To: "Korenblit, Miriam Rachel" <miriam.rachel.korenblit@...el.com>
Cc: Arnd Bergmann <arnd@...nel.org>, Arnd Bergmann <arnd@...db.de>,
	"Berg, Johannes" <johannes.berg@...el.com>,
	"Grumbach, Emmanuel" <emmanuel.grumbach@...el.com>,
	"Berg, Benjamin" <benjamin.berg@...el.com>,
	"Anjaneyulu, Pagadala Yesu" <pagadala.yesu.anjaneyulu@...el.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iwlwifi: mld: fix building with CONFIG_PM_SLEEP disabled

On Sun, Mar 30, 2025 at 04:49:38AM +0000, Korenblit, Miriam Rachel wrote:
> > From: Arnd Bergmann <arnd@...nel.org>
> > Sent: Tuesday, 25 March 2025 10:44
> > 
> > The newly added driver causes multiple build problems when CONFIG_PM_SLEEP
> > is disabled:
[...]
> > --- a/drivers/net/wireless/intel/iwlwifi/mld/mac80211.c
> > +++ b/drivers/net/wireless/intel/iwlwifi/mld/mac80211.c
> > @@ -501,7 +501,7 @@ int iwl_mld_mac80211_start(struct ieee80211_hw *hw)
> >  		iwl_mld_restart_cleanup(mld);
> >  	}
> > 
> > -	if (!in_d3 || ret) {
> > +	if (!in_d3) {
> 
> Then where do you handle the in_d3 && ret case?

That seems to be a valid objection, yet Arnd's patch is now
commit 44605365f935 in wireless.git:

https://git.kernel.org/wireless/wireless/c/44605365f935

I'm proposing this v2:

https://lore.kernel.org/r/f435bd9c8186176ffa12fd3650fac71cacdeebe1.1743946314.git.lukas@wunner.de/

If wireless.git/main is a rebasing branch, consider replacing the
above-linked commit with the new version.  If it is not a rebasing
branch, let me know and I'll send a patch reinstating only the ret
in the if-condition.

Thanks,

Lukas