linux-kernel - Re: [PATCH v3] hwmon: (max77705) add initial support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202504062351.7jqIfzxh-lkp@intel.com>
Date: Sun, 6 Apr 2025 23:36:10 +0800
From: kernel test robot <lkp@...el.com>
To: Dzmitry Sankouski <dsankouski@...il.com>,
	Jean Delvare <jdelvare@...e.com>,
	Guenter Roeck <linux@...ck-us.net>,
	Jonathan Corbet <corbet@....net>,
	Chanwoo Choi <cw00.choi@...sung.com>,
	Krzysztof Kozlowski <krzk@...nel.org>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-hwmon@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Dzmitry Sankouski <dsankouski@...il.com>
Subject: Re: [PATCH v3] hwmon: (max77705) add initial support

Hi Dzmitry,

kernel test robot noticed the following build warnings:

[auto build test WARNING on a4cda136f021ad44b8b52286aafd613030a6db5f]

url:    https://github.com/intel-lab-lkp/linux/commits/Dzmitry-Sankouski/hwmon-max77705-add-initial-support/20250405-233235
base:   a4cda136f021ad44b8b52286aafd613030a6db5f
patch link:    https://lore.kernel.org/r/20250405-initial-support-for-max77705-sensors-v3-1-e5f64fccd005%40gmail.com
patch subject: [PATCH v3] hwmon: (max77705) add initial support
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20250406/202504062351.7jqIfzxh-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250406/202504062351.7jqIfzxh-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504062351.7jqIfzxh-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/hwmon/max77705-hwmon.c:116:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
     116 |                 default:
         |                 ^
   drivers/hwmon/max77705-hwmon.c:116:3: note: insert 'break;' to avoid fall-through
     116 |                 default:
         |                 ^
         |                 break; 
>> drivers/hwmon/max77705-hwmon.c:66:35: warning: unused variable 'max77705_hwmon_regmap_config' [-Wunused-const-variable]
      66 | static const struct regmap_config max77705_hwmon_regmap_config = {
         |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   2 warnings generated.


vim +116 drivers/hwmon/max77705-hwmon.c

    65	
  > 66	static const struct regmap_config max77705_hwmon_regmap_config = {
    67		.name = "max77705_hwmon",
    68		.reg_bits = 8,
    69		.val_bits = 16,
    70		.rd_table = &max77705_hwmon_readable_table,
    71		.max_register = MAX77705_FG_END,
    72		.val_format_endian = REGMAP_ENDIAN_LITTLE
    73	};
    74	
    75	static int max77705_read_and_convert(struct regmap *regmap, u8 reg, u32 res, long *val)
    76	{
    77		int ret;
    78		u32 regval;
    79	
    80		ret = regmap_read(regmap, reg, &regval);
    81		if (ret < 0)
    82			return ret;
    83		*val = mult_frac((long)regval, res, 1000000);
    84	
    85		return 0;
    86	}
    87	
    88	static umode_t max77705_is_visible(const void *data,
    89					   enum hwmon_sensor_types type,
    90					   u32 attr, int channel)
    91	{
    92		switch (type) {
    93		case hwmon_in:
    94			if (channel >= ARRAY_SIZE(voltage_channel_desc))
    95				return 0;
    96	
    97			switch (attr) {
    98			case hwmon_in_input:
    99			case hwmon_in_label:
   100				return 0444;
   101			default:
   102				break;
   103			}
   104			break;
   105		case hwmon_curr:
   106			if (channel >= ARRAY_SIZE(current_channel_desc))
   107				return 0;
   108	
   109			switch (attr) {
   110			case hwmon_curr_input:
   111			case hwmon_in_label:
   112				return 0444;
   113			case hwmon_curr_average:
   114				if (current_channel_desc[channel].avg_reg)
   115					return 0444;
 > 116			default:
   117				break;
   118			}
   119			break;
   120		default:
   121			break;
   122		}
   123		return 0;
   124	}
   125	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki