linux-kernel - Re: [PATCH v4 1/1] scsi: ufs: core: add device level exception support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ouxmroni4miwrzd24gvcvo3v5hqthodhhx3ohk4i37qryn4k2w@47s2a6nvxby6>
Date: Sun, 6 Apr 2025 23:53:41 +0530
From: 
	"manivannan.sadhasivam@...aro.org" <manivannan.sadhasivam@...aro.org>
To: "Bao D. Nguyen" <quic_nguyenb@...cinc.com>
Cc: Bart Van Assche <bvanassche@....org>, 
	Arthur Simchaev <Arthur.Simchaev@...disk.com>, "quic_cang@...cinc.com" <quic_cang@...cinc.com>, 
	"quic_nitirawa@...cinc.com" <quic_nitirawa@...cinc.com>, "avri.altman@....com" <avri.altman@....com>, 
	"peter.wang@...iatek.com" <peter.wang@...iatek.com>, "minwoo.im@...sung.com" <minwoo.im@...sung.com>, 
	"adrian.hunter@...el.com" <adrian.hunter@...el.com>, "martin.petersen@...cle.com" <martin.petersen@...cle.com>, 
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>, Alim Akhtar <alim.akhtar@...sung.com>, 
	"James E.J. Bottomley" <James.Bottomley@...senpartnership.com>, Matthias Brugger <matthias.bgg@...il.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Bean Huo <beanhuo@...ron.com>, 
	Keoseong Park <keosung.park@...sung.com>, Ziqi Chen <quic_ziqichen@...cinc.com>, 
	Al Viro <viro@...iv.linux.org.uk>, Gwendal Grignou <gwendal@...omium.org>, 
	Eric Biggers <ebiggers@...gle.com>, open list <linux-kernel@...r.kernel.org>, 
	"moderated list:ARM/Mediatek SoC support:Keyword:mediatek" <linux-arm-kernel@...ts.infradead.org>, 
	"moderated list:ARM/Mediatek SoC support:Keyword:mediatek" <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH v4 1/1] scsi: ufs: core: add device level exception
 support

On Wed, Apr 02, 2025 at 12:00:26PM -0700, Bao D. Nguyen wrote:
> On 4/2/2025 12:49 AM, manivannan.sadhasivam@...aro.org wrote:
> > Yeah, we should be cautious in changing the uAPI header as it can break the
> > userspace applications. Annotating the members that need packed attribute seems
> > like the way forward to me.
> 
> Yes, I realized potential issue when Bart raised a concern.
> 
> > 
> > Though, I'd like to understand which architecture has the alignment constraint
> > in this structure. Only if an architecture requires 8 byte alignment for __be32
> > would be a problem. That too only for osf7 and reserved. But I'm not aware of
> > such architectures in use.
> When using "__u64 value;" in place of osf3-6, I saw the compiler padded 4
> bytes, so __packed was needed for me to get correct __u64 value. I thought
> even the existing structure utp_upiu_query_v4_0 may need __packed on some
> fields where the driver reads the returned data in order to be safe across
> all architectures. However, without evidence of an actual failure, I didn't
> touch the existing structure. Only raised potential issue for discussion.
> 

If you change members to be 64bit, then for sure compiler will add padding to
avoid holes. But I don't see any issue with the unchanged utp_upiu_query_v4_0
structure.

- Mani

-- 
மணிவண்ணன் சதாசிவம்