[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <522befcba0d8e5efe089b6fb22049cd74cfb4ead.camel@mediatek.com>
Date: Sun, 6 Apr 2025 08:04:52 +0000
From: Xiangzhi Tang (唐相志)
<Xiangzhi.Tang@...iatek.com>
To: "robh@...nel.org" <robh@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
"linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
Hailong Fan (范海龙) <Hailong.Fan@...iatek.com>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@...iatek.com>, "conor+dt@...nel.org"
<conor+dt@...nel.org>, "linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
Jjian Zhou (周建) <Jjian.Zhou@...iatek.com>,
"matthias.bgg@...il.com" <matthias.bgg@...il.com>, "krzk+dt@...nel.org"
<krzk+dt@...nel.org>, "andersson@...nel.org" <andersson@...nel.org>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
"mathieu.poirier@...aro.org" <mathieu.poirier@...aro.org>
Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: Add VCP support for mt8196
On Wed, 2025-04-02 at 07:55 -0500, Rob Herring (Arm) wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> On Wed, 02 Apr 2025 17:19:24 +0800, Xiangzhi Tang wrote:
> > Add the new binding document for MediaTek Video Companion
> > Processor(VCP) on MediaTek mt8196.
> >
> > Signed-off-by: Xiangzhi Tang <xiangzhi.tang@...iatek.com>
> > ---
> > .../remoteproc/mediatek,mt8196-vcp.yaml | 174
> > ++++++++++++++++++
> > 1 file changed, 174 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/remoteproc/mediatek,mt8196-
> > vcp.yaml
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/remoteproc/mediatek,mt8196-
> vcp.example.dts:26:18: fatal error: dt-bindings/power/mt8196-power.h:
> No such file or directory
> 26 | #include <dt-bindings/power/mt8196-power.h>
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> make[2]: *** [scripts/Makefile.dtbs:131:
> Documentation/devicetree/bindings/remoteproc/mediatek,mt8196-
> vcp.example.dtb] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1522:
> dt_binding_check] Error 2
> make: *** [Makefile:248: __sub-make] Error 2
>
> doc reference errors (make refcheckdocs):
> Warning:
> Documentation/devicetree/bindings/remoteproc/mediatek,mt8196-vcp.yaml
> references a file that doesn't exist:
> Documentation/devicetree/bindings/mailbox/mediatek,mt8196-vcp-
> mbox.yaml
> Documentation/devicetree/bindings/remoteproc/mediatek,mt8196-
> vcp.yaml: Documentation/devicetree/bindings/mailbox/mediatek,mt8196-
> vcp-mbox.yaml
>
> See
> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250402092134.12293-2-xiangzhi.tang@mediatek.com
>
> The base for the series is generally the latest rc1. A different
> dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up
> to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself.
> Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up
> checking
> your schema. However, it must be unset to test all examples with your
> schema.
> I run test "make dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/remoteproc/mediatek,m
t8196-vcp.yaml", And, I have to cherry-pick first "
https://lore.kernel.org/all/20250307032942.10447-1-guangjie.song@mediatek.com/
" and "
https://patchwork.kernel.org/project/linux-mediatek/patch/20250317110331.2776-4-jjian.zhou@mediatek.com/
"
>
Powered by blists - more mailing lists