linux-kernel - Re: [PATCH v4 1/5] dt-bindings: leds: add TI/National Semiconductor LP5812 LED Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eac877d0-2fd3-44cf-8917-910042cdcec9@kernel.org>
Date: Sun, 6 Apr 2025 13:59:53 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Nam Tran <trannamatk@...il.com>, pavel@...nel.org, lee@...nel.org,
 krzk+dt@...nel.org, robh@...nel.org, conor+dt@...nel.org, corbet@....net
Cc: devicetree@...r.kernel.org, linux-leds@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/5] dt-bindings: leds: add TI/National Semiconductor
 LP5812 LED Driver

On 05/04/2025 20:32, Nam Tran wrote:
> +properties:
> +  compatible:
> +    const: ti,lp5812
> +
> +  reg:
> +    maxItems: 1
> +    description:
> +      I2C slave address
> +      lp5812/12- 0x1b

Drop description, redundant.

> +
> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 0
> +
> +patternProperties:
> +  "^led@[0-9a-b]$":
> +    type: object
> +    $ref: common.yaml#
> +    unevaluatedProperties: false
> +
> +    properties:
> +      reg:
> +        minimum: 0
> +        maximum: 0xb
> +
> +      chan-name:
> +        $ref: /schemas/types.yaml#/definitions/string
> +        description: LED channel name

Isn't this existing label property? Or node name? You don't need this
and instead whatever currently LED subsystem is expecting (label got
discouraged so maybe there is something else now).


There is no multi-led support in the device? Datasheet this can work as
matrix and as direct drive of 4 LEDs, so binding looks incomplete. Not
sure what you exactly miss here - check other recent devices with
similar features.

> +
> +    required:
> +      - reg
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/leds/common.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        led-controller@1b {
> +            compatible = "ti,lp5812";
> +            reg = <0x1b>;
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +
> +            led@0 {
> +                    reg = <0x0>;
> +                    chan-name = "a0";

Mixed up indentation.


Best regards,
Krzysztof