linux-kernel - Re: [PATCH 2/2] remoterpoc: mediatek: vcp: Add vcp remoteproc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4479a68e-6a8d-4197-b983-90eae8e16c6c@kernel.org>
Date: Sun, 6 Apr 2025 14:12:08 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Xiangzhi Tang (唐相志)
 <Xiangzhi.Tang@...iatek.com>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "robh@...nel.org" <robh@...nel.org>,
 "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
 "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
 "andersson@...nel.org" <andersson@...nel.org>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 "mathieu.poirier@...aro.org" <mathieu.poirier@...aro.org>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
 "linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 Hailong Fan (范海龙) <Hailong.Fan@...iatek.com>,
 Project_Global_Chrome_Upstream_Group
 <Project_Global_Chrome_Upstream_Group@...iatek.com>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 Jjian Zhou (周建) <Jjian.Zhou@...iatek.com>
Subject: Re: [PATCH 2/2] remoterpoc: mediatek: vcp: Add vcp remoteproc driver

On 06/04/2025 09:29, Xiangzhi Tang (唐相志) wrote:
> On Wed, 2025-04-02 at 13:16 +0200, Krzysztof Kozlowski wrote:
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>


Please kindly trim the replies from unnecessary context. It makes it
much easier to find new content.


>>> +
>>> +     for_each_available_child_of_node(np, child) {
>>> +             if (of_device_is_compatible(child, "mediatek,vcp-
>>> core")) {
>>> +                     cpdev = of_find_device_by_node(child);
>>> +                     if (!cpdev) {
>>> +                             ret = -ENODEV;
>>> +                             dev_err(dev, "Not found platform
>>> device for core\n");
>>
>> You leak np, use scoped.
>> I'm not quite able to understand your meaning, Could you please
> explain it for me? Thanks very much.

Use proper quoting. Above makes no sense - you put your reply into my quote.

Explanation: You leak 'np'. Don't leak. Either drop reference or use
scoped loops. Look how every other driver does it. Read the API, read
the doc.

You ignored all other comments, so I assume you will implement them fully.

Best regards,
Krzysztof