linux-kernel - Re: [PATCH] RISC-V: Kconfig: Fix help text of CMDLINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4b2a6bf1-3642-431b-bb74-3aeae79d17d3@ghiti.fr>
Date: Mon, 7 Apr 2025 14:47:31 +0200
From: Alexandre Ghiti <alex@...ti.fr>
To: Yeking@...54.com, linux-riscv@...ts.infradead.org
Cc: Paul Walmsley <paul.walmsley@...ive.com>,
 Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Nick Kossifidis <mick@....forth.gr>, Debbie Maliotaki
 <dmaliotaki@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RISC-V: Kconfig: Fix help text of CMDLINE_EXTEND

Hi XIE Zhibang,

On 28/03/2025 11:14, Yeking@...54.com wrote:
> From: 谢致邦 (XIE Zhibang) <Yeking@...54.com>
>
> It is the built-in command line appended to the bootloader command line,
> not the bootloader command line appended to the built-in command line.
>
> Fixes: 3aed8c43267e ("RISC-V: Update Kconfig to better handle CMDLINE")
> Signed-off-by: 谢致邦 (XIE Zhibang) <Yeking@...54.com>
> ---
>   arch/riscv/Kconfig | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index 54ed2a8cd7af..4cd18d0d07b3 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -1144,8 +1144,8 @@ config CMDLINE_FALLBACK
>   config CMDLINE_EXTEND
>   	bool "Extend bootloader kernel arguments"
>   	help
> -	  The command-line arguments provided during boot will be
> -	  appended to the built-in command line. This is useful in
> +	  The built-in command line will be appended to the command-
> +	  line arguments provided during boot. This is useful in
>   	  cases where the provided arguments are insufficient and
>   	  you don't want to or cannot modify them.
>   


It seems that you're correct 
(https://elixir.bootlin.com/linux/v6.14-rc6/source/drivers/of/fdt.c#L1065).

I noticed that all the architectures that define this config have the 
same text, so I guess the behavior changed at some point.

I would suggest to fix all the architectures and find which commit 
changed this behavior.

Thanks,

Alex