linux-kernel - [PATCH v2 3/3] cfg80211: Remove WARN_ON() in cfg80211_pernet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250407125345.1238818-4-i.abramov@mt-integration.ru>
Date: Mon, 7 Apr 2025 15:53:44 +0300
From: Ivan Abramov <i.abramov@...integration.ru>
To: Johannes Berg <johannes@...solutions.net>
CC: Ivan Abramov <i.abramov@...integration.ru>, Kuniyuki Iwashima
	<kuniyu@...zon.com>, <linux-wireless@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <lvc-project@...uxtesting.org>
Subject: [PATCH v2 3/3] cfg80211: Remove WARN_ON() in cfg80211_pernet_exit()

There's no need to call WARN_ON() in cfg80211_pernet_exit(), since
every point of failure in cfg80211_switch_netns() is covered with
WARN_ON(), so remove it.

Found by Linux Verification Center (linuxtesting.org).

Fixes: 463d01832385 ("cfg80211: make aware of net namespaces")
Suggested-by: Kuniyuki Iwashima <kuniyu@...zon.com>
Signed-off-by: Ivan Abramov <i.abramov@...integration.ru>
---
 net/wireless/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/wireless/core.c b/net/wireless/core.c
index 6f95aad18d47..b77f4ed8f2c0 100644
--- a/net/wireless/core.c
+++ b/net/wireless/core.c
@@ -1656,7 +1656,7 @@ static void __net_exit cfg80211_pernet_exit(struct net *net)
 	rtnl_lock();
 	for_each_rdev(rdev) {
 		if (net_eq(wiphy_net(&rdev->wiphy), net))
-			WARN_ON(cfg80211_switch_netns(rdev, &init_net));
+			cfg80211_switch_netns(rdev, &init_net);
 	}
 	rtnl_unlock();
 }
-- 
2.39.5