linux-kernel - Re: [PATCH] crypto: atmel - add CRYPTO_ALG_KERN_DRIVER_ONLY flag to atmel-aes, atmel-sha, atmel-tdes drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z_NIf4EEeLRv4fFT@gondor.apana.org.au>
Date: Mon, 7 Apr 2025 11:37:35 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Zixun LI <admin@...iphile.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Nicolas Ferre <nicolas.ferre@...rochip.com>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Claudiu Beznea <claudiu.beznea@...on.dev>,
	linux-crypto@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: atmel - add CRYPTO_ALG_KERN_DRIVER_ONLY flag to
 atmel-aes, atmel-sha, atmel-tdes drivers

On Wed, Mar 19, 2025 at 04:06:56PM +0100, Zixun LI wrote:
> 
> diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c
> index 90dcae7049b7..8a6ee5ac9956 100644
> --- a/drivers/crypto/atmel-aes.c
> +++ b/drivers/crypto/atmel-aes.c
> @@ -1948,7 +1948,8 @@ static struct skcipher_alg aes_xts_alg = {
>  	.base.cra_driver_name	= "atmel-xts-aes",
>  	.base.cra_blocksize	= AES_BLOCK_SIZE,
>  	.base.cra_ctxsize	= sizeof(struct atmel_aes_xts_ctx),
> -	.base.cra_flags		= CRYPTO_ALG_NEED_FALLBACK,
> +	.base.cra_flags		= CRYPTO_ALG_NEED_FALLBACK |
> +						  CRYPTO_ALG_KERN_DRIVER_ONLY,

This should be indented like this:

	.base.cra_flags		= CRYPTO_ALG_NEED_FALLBACK |
				  CRYPTO_ALG_KERN_DRIVER_ONLY,

> diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
> index 3622120add62..40f6ed5b20ee 100644
> --- a/drivers/crypto/atmel-sha.c
> +++ b/drivers/crypto/atmel-sha.c
> @@ -1254,7 +1254,8 @@ static int atmel_sha_cra_init(struct crypto_tfm *tfm)
>  static void atmel_sha_alg_init(struct ahash_alg *alg)
>  {
>  	alg->halg.base.cra_priority = ATMEL_SHA_PRIORITY;
> -	alg->halg.base.cra_flags = CRYPTO_ALG_ASYNC;
> +	alg->halg.base.cra_flags = CRYPTO_ALG_ASYNC |
> +							   CRYPTO_ALG_KERN_DRIVER_ONLY;

	alg->halg.base.cra_flags = CRYPTO_ALG_ASYNC |
				   CRYPTO_ALG_KERN_DRIVER_ONLY;

> @@ -2043,7 +2044,8 @@ static void atmel_sha_hmac_cra_exit(struct crypto_tfm *tfm)
>  static void atmel_sha_hmac_alg_init(struct ahash_alg *alg)
>  {
>  	alg->halg.base.cra_priority = ATMEL_SHA_PRIORITY;
> -	alg->halg.base.cra_flags = CRYPTO_ALG_ASYNC;
> +	alg->halg.base.cra_flags = CRYPTO_ALG_ASYNC |
> +							   CRYPTO_ALG_KERN_DRIVER_ONLY;

	alg->halg.base.cra_flags = CRYPTO_ALG_ASYNC |
				   CRYPTO_ALG_KERN_DRIVER_ONLY;

> diff --git a/drivers/crypto/atmel-tdes.c b/drivers/crypto/atmel-tdes.c
> index 099b32a10dd7..3a6a890172cd 100644
> --- a/drivers/crypto/atmel-tdes.c
> +++ b/drivers/crypto/atmel-tdes.c
> @@ -898,7 +898,8 @@ static int atmel_tdes_init_tfm(struct crypto_skcipher *tfm)
>  static void atmel_tdes_skcipher_alg_init(struct skcipher_alg *alg)
>  {
>  	alg->base.cra_priority = ATMEL_TDES_PRIORITY;
> -	alg->base.cra_flags = CRYPTO_ALG_ASYNC;
> +	alg->base.cra_flags = CRYPTO_ALG_ASYNC |
> +						  CRYPTO_ALG_KERN_DRIVER_ONLY;

This fits on one line, no need to split.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt