[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250407134523.d56rjpydflmkw2ze@privatize>
Date: Mon, 7 Apr 2025 08:45:23 -0500
From: Nishanth Menon <nm@...com>
To: Yemike Abhilash Chandra <y-abhilashchandra@...com>
CC: <vigneshr@...com>, <kristo@...nel.org>, <robh@...nel.org>,
<krzk+dt@...nel.org>, <conor+dt@...nel.org>, <vaishnav.a@...com>,
<jai.luthra@...ux.dev>, <linux-arm-kernel@...ts.infradead.org>,
<devicetree@...r.kernel.org>, <imx@...ts.linux.dev>,
<linux-kernel@...r.kernel.org>, <u-kumar1@...com>
Subject: Re: [PATCH 3/5] arm64: dts: ti: k3-j721e-sk: Fix dtbs_check warnings
in IMX219 overlay
$subject - the patch adds description for the supplies for the sensor.
Please fix the description.
On 17:10-20250401, Yemike Abhilash Chandra wrote:
> The device tree bindings mandate three regulator nodes for the IMX219
> sensor: VANA (analog), VDIG (digital core), and VDDL (digital I/O). Add the
> necessary regulator nodes in the device tree overlay and also the device
> tree bindings do not include a clock-names property. Remove the incorrectly
> added clock-names entry to avoid dtbs_check warnings.
>
> Fixes: f767eb918096 ("arm64: dts: ti: k3-j721e-sk: Add overlay for IMX219")
> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@...com>
> ---
> .../dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso | 35 +++++++++++++++++--
> 1 file changed, 33 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso b/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso
> index 47bb5480b5b0..4eb3cffab032 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso
> @@ -19,6 +19,33 @@ clk_imx219_fixed: imx219-xclk {
> #clock-cells = <0>;
> clock-frequency = <24000000>;
> };
> +
> + reg_2p8v: regulator-2p8v {
> + compatible = "regulator-fixed";
> + regulator-name = "2P8V";
> + regulator-min-microvolt = <2800000>;
> + regulator-max-microvolt = <2800000>;
> + vin-supply = <&vdd_sd_dv>;
> + regulator-always-on;
> + };
> +
> + reg_1p8v: regulator-1p8v {
> + compatible = "regulator-fixed";
> + regulator-name = "1P8V";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + vin-supply = <&vdd_sd_dv>;
> + regulator-always-on;
> + };
> +
> + reg_1p2v: regulator-1p2v {
> + compatible = "regulator-fixed";
> + regulator-name = "1P2V";
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1200000>;
> + vin-supply = <&vdd_sd_dv>;
> + regulator-always-on;
> + };
> };
>
> &csi_mux {
> @@ -34,7 +61,9 @@ imx219_0: imx219-0@10 {
> reg = <0x10>;
>
> clocks = <&clk_imx219_fixed>;
> - clock-names = "xclk";
> + VANA-supply = <®_2p8v>;
> + VDIG-supply = <®_1p8v>;
> + VDDL-supply = <®_1p2v>;
>
> port {
> csi2_cam0: endpoint {
> @@ -56,7 +85,9 @@ imx219_1: imx219-1@10 {
> reg = <0x10>;
>
> clocks = <&clk_imx219_fixed>;
> - clock-names = "xclk";
> + VANA-supply = <®_2p8v>;
> + VDIG-supply = <®_1p8v>;
> + VDDL-supply = <®_1p2v>;
>
> port {
> csi2_cam1: endpoint {
> --
> 2.34.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
Powered by blists - more mailing lists