[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Z_PXRQB9zgmXvpEA@kuha.fi.intel.com>
Date: Mon, 7 Apr 2025 16:46:45 +0300
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Michael Grzeschik <m.grzeschik@...gutronix.de>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
kernel@...gutronix.de, Badhri Jagan Sridharan <badhri@...gle.com>
Subject: Re: [PATCH 1/3] usb: typec: tcpm: allow to use sink in accessory mode
+Badhri
On Fri, Apr 04, 2025 at 12:43:04AM +0200, Michael Grzeschik wrote:
> Since the function tcpm_acc_attach is not setting the data and role for
> for the sink case we extend it to check for it first.
>
> Signed-off-by: Michael Grzeschik <m.grzeschik@...gutronix.de>
Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> ---
> drivers/usb/typec/tcpm/tcpm.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index a99db4e025cd0..839697c14265e 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -4551,12 +4551,17 @@ static void tcpm_snk_detach(struct tcpm_port *port)
> static int tcpm_acc_attach(struct tcpm_port *port)
> {
> int ret;
> + enum typec_role role;
> + enum typec_data_role data;
>
> if (port->attached)
> return 0;
>
> - ret = tcpm_set_roles(port, true, TYPEC_SOURCE,
> - tcpm_data_role_for_source(port));
> + role = tcpm_port_is_sink(port) ? TYPEC_SINK : TYPEC_SOURCE;
> + data = tcpm_port_is_sink(port) ? tcpm_data_role_for_sink(port)
> + : tcpm_data_role_for_source(port);
> +
> + ret = tcpm_set_roles(port, true, role, data);
> if (ret < 0)
> return ret;
>
--
heikki
Powered by blists - more mailing lists