linux-kernel - Re: [PATCH] usb: typec: tcpci: add regulator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z_PYhMbmNv6dWM4w@kuha.fi.intel.com>
Date: Mon, 7 Apr 2025 16:52:04 +0300
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Michael Grzeschik <m.grzeschik@...gutronix.de>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel@...gutronix.de, Badhri Jagan Sridharan <badhri@...gle.com>
Subject: Re: [PATCH] usb: typec: tcpci: add regulator support

+Badhri

On Fri, Apr 04, 2025 at 01:17:20AM +0200, Michael Grzeschik wrote:
> The tcpci chip vbus pin is possibly driven by an regulator. This patch
> is adding support to enable an optional vdd regulator before probing.
> 
> Signed-off-by: Michael Grzeschik <m.grzeschik@...gutronix.de>

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/tcpm/tcpci.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/usb/typec/tcpm/tcpci.c b/drivers/usb/typec/tcpm/tcpci.c
> index 19ab6647af706..a56e31b20c214 100644
> --- a/drivers/usb/typec/tcpm/tcpci.c
> +++ b/drivers/usb/typec/tcpm/tcpci.c
> @@ -17,6 +17,7 @@
>  #include <linux/usb/tcpci.h>
>  #include <linux/usb/tcpm.h>
>  #include <linux/usb/typec.h>
> +#include <linux/regulator/consumer.h>
>  
>  #define	PD_RETRY_COUNT_DEFAULT			3
>  #define	PD_RETRY_COUNT_3_0_OR_HIGHER		2
> @@ -905,6 +906,10 @@ static int tcpci_probe(struct i2c_client *client)
>  	int err;
>  	u16 val = 0;
>  
> +	err = devm_regulator_get_enable_optional(&client->dev, "vdd");
> +	if (err && err != -ENODEV)
> +		return dev_err_probe(&client->dev, err, "Failed to get regulator\n");
> +
>  	chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
>  	if (!chip)
>  		return -ENOMEM;
> 
> ---
> base-commit: a1b5bd45d4ee58af4f56e49497b8c3db96d8f8a3
> change-id: 20250404-ml-topic-tcpci-524d1d6bfede
> 
> Best regards,
> -- 
> Michael Grzeschik <m.grzeschik@...gutronix.de>

-- 
heikki