linux-kernel - Re: [PATCH] clk: sophgo: Fixes Coccinelle/coccicheck warnings reported by do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <h765x3o4lndngmcllxst5pqsz5p6xmi6rd7qc63ntd6xklghk2@4gbg4x6tcwgq>
Date: Mon, 7 Apr 2025 11:55:20 +0800
From: Inochi Amaoto <inochiama@...il.com>
To: xiaopeitux@...mail.com, sboyd@...nel.org, mturquette@...libre.com, 
	unicorn_wang@...look.com, inochiama@...il.com, linux-clk@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Cc: Pei Xiao <xiaopei01@...inos.cn>
Subject: Re: [PATCH] clk: sophgo: Fixes Coccinelle/coccicheck warnings
 reported by do_div.cocci.

On Mon, Apr 07, 2025 at 11:21:46AM +0800, xiaopeitux@...mail.com wrote:
> From: Pei Xiao <xiaopei01@...inos.cn>
> 
> cocci warnings:
>     drivers/clk/sophgo/clk-sg2042-pll.c:217:1-7: WARNING:
>     do_div() does a 64-by-32 division, please consider using div64_ul
>     instead.
> 
>     drivers/clk/sophgo/clk-sg2042-pll.c:160:1-7: WARNING:
>     do_div() does a 64-by-32 division, please consider using div64_u64
>     instead.
> 
> replace do_div() with div64_*() which doesn't implicitly cast the divisor.
> 
> Signed-off-by: Pei Xiao <xiaopei01@...inos.cn>
> ---
>  drivers/clk/sophgo/clk-sg2042-pll.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

LGTM.

Reviewed-by: Inochi Amaoto <inochiama@...il.com>