[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <75f23255-afde-4241-be7b-a12620814d2c@amd.com>
Date: Mon, 7 Apr 2025 09:34:57 -0500
From: "Bowman, Terry" <terry.bowman@....com>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>
Cc: linux-cxl@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-pci@...r.kernel.org, nifan.cxl@...il.com, dave@...olabs.net,
dave.jiang@...el.com, alison.schofield@...el.com, vishal.l.verma@...el.com,
dan.j.williams@...el.com, bhelgaas@...gle.com, mahesh@...ux.ibm.com,
ira.weiny@...el.com, oohall@...il.com, Benjamin.Cheatham@....com,
rrichter@....com, nathan.fontenot@....com,
Smita.KoralahalliChannabasappa@....com, lukas@...ner.de,
ming.li@...omail.com, PradeepVineshReddy.Kodamati@....com
Subject: Re: [PATCH v8 15/16] CXL/PCI: Enable CXL protocol errors during CXL
Port probe
On 4/4/2025 12:05 PM, Jonathan Cameron wrote:
> On Wed, 26 Mar 2025 20:47:16 -0500
> Terry Bowman <terry.bowman@....com> wrote:
>
>> CXL protocol errors are not enabled for all CXL devices at boot. These
>> must be enabled inorder to process CXL protocol errors.
>>
>> Export the AER service driver's pci_aer_unmask_internal_errors().
>>
>> Introduce cxl_enable_port_errors() to call pci_aer_unmask_internal_errors().
>> pci_aer_unmask_internal_errors() expects the pdev->aer_cap is initialized.
>> But, dev->aer_cap is not initialized for CXL Upstream Switch Ports and CXL
>> Downstream Switch Ports. Initialize the dev->aer_cap if necessary. Enable AER
>> correctable internal errors and uncorrectable internal errors for all CXL
>> devices.
>>
>> Signed-off-by: Terry Bowman <terry.bowman@....com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
Thanks for reviewing.
Terry
Powered by blists - more mailing lists