linux-kernel - Re: [PATCH 1/2] KVM: TDX: Handle TDG.VP.VMCALL<GetQuote>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84d44db2-6327-43db-93c9-61823f4d90aa@linux.intel.com>
Date: Mon, 7 Apr 2025 09:00:28 +0800
From: Binbin Wu <binbin.wu@...ux.intel.com>
To: "Huang, Kai" <kai.huang@...el.com>,
 "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
 "pbonzini@...hat.com" <pbonzini@...hat.com>,
 "seanjc@...gle.com" <seanjc@...gle.com>
Cc: "Gao, Chao" <chao.gao@...el.com>,
 "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>,
 "mikko.ylinen@...ux.intel.com" <mikko.ylinen@...ux.intel.com>,
 "Li, Xiaoyao" <xiaoyao.li@...el.com>,
 "Lindgren, Tony" <tony.lindgren@...el.com>,
 "Hunter, Adrian" <adrian.hunter@...el.com>,
 "Chatre, Reinette" <reinette.chatre@...el.com>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "Zhao, Yan Y" <yan.y.zhao@...el.com>,
 "Yamahata, Isaku" <isaku.yamahata@...el.com>
Subject: Re: [PATCH 1/2] KVM: TDX: Handle TDG.VP.VMCALL<GetQuote>



On 4/3/2025 6:19 AM, Huang, Kai wrote:
> On Wed, 2025-04-02 at 08:15 +0800, Binbin Wu wrote:
>> +::
>> +
>> +		/* KVM_EXIT_TDX_GET_QUOTE */
>> +		struct tdx_get_quote {
>> +			__u64 ret;
>> +			__u64 gpa;
>> +			__u64 size;
>> +		};
>> +
> The shared buffer pointed by the @gpa also has a format defined in the GHCI
> spec.  E.g., it has a 'status code' field.  Does userspace VMM need to setup
> this 'status code' as well?

Yes.
>
> I recall that we used to set the GET_QUOTE_IN_FLIGHT flag in Qemu but not sure
> whether it is still true?
It's still true.

>
> I am thinking if Qemu needs to set it, then we need to expose the structure of
> the shared buffer to userspace too.

For the structure of the shared buffer, since KVM doesn't care about it.
IMHO, it's not necessary to define the structure in KVM and userspace can
define the structure according to GHCI directly.