linux-kernel - Re: [PATCH v2] nvme-tcp: Fix netns UAF introduced by commit 1be52169c348

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250407143121.GA11876@lst.de>
Date: Mon, 7 Apr 2025 16:31:21 +0200
From: Christoph Hellwig <hch@....de>
To: shaopeijie@...tc.cn
Cc: kbusch@...nel.org, sagi@...mberg.me, axboe@...nel.dk, hch@....de,
	linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org,
	gechangzhong@...tc.cn, zhang.guanghui@...tc.cn,
	netdev@...r.kernel.org
Subject: Re: [PATCH v2] nvme-tcp: Fix netns UAF introduced by commit
 1be52169c348

I had another look at this patch, and it feels wrong to me.  I don't
think we are supposed to create sockets triggered by activity in
a network namespace in the global namespace even if they are indirectly
created through the nvme interface.  But maybe I'm misunderstanding
how network namespaces work, which is entirely possible.

So to avoid the failure I'd be tempted to instead revert commit
1be52169c348 until the problem is fully sorted out.