Message-ID: <20250407-drm-bridge-convert-to-alloc-api-v1-33-42113ff8d9c0@bootlin.com>
Date: Mon,  7 Apr 2025 17:27:08 +0200
From: Luca Ceresoli <luca.ceresoli@...tlin.com>
To: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>,
	Simona Vetter <simona@...ll.ch>,
	Andrzej Hajda <andrzej.hajda@...el.com>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Robert Foss <rfoss@...nel.org>,
	Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
	Jonas Karlman <jonas@...boo.se>,
	Jernej Skrabec <jernej.skrabec@...il.com>,
	Jagan Teki <jagan@...rulasolutions.com>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Douglas Anderson <dianders@...omium.org>,
	Chun-Kuang Hu <chunkuang.hu@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Luca Ceresoli <luca.ceresoli@...tlin.com>,
	Anusha Srivatsa <asrivats@...hat.com>,
	Paul Kocialkowski <paulk@...-base.io>,
	Dmitry Baryshkov <lumag@...nel.org>,
	Hervé Codina <herve.codina@...tlin.com>,
	Hui Pu <Hui.Pu@...ealthcare.com>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	dri-devel@...ts.freedesktop.org,
	asahi@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	chrome-platform@...ts.linux.dev,
	imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org,
	linux-amlogic@...ts.infradead.org,
	linux-renesas-soc@...r.kernel.org,
	platform-driver-x86@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org,
	linux-arm-msm@...r.kernel.org,
	freedreno@...ts.freedesktop.org,
	linux-stm32@...md-mailman.stormreply.com
Subject: [PATCH 33/34] drm/bridge: add devm_drm_put_bridge()

Bridges obtained via devm_drm_bridge_alloc(dev, ...) will be put when the
requesting device (@dev) is removed.

However drivers which obtained them may need to put the obtained reference
explicitly. One such case is if they bind the devm removal action to a
different device than the one implemented by the driver itself and which
might be removed at a different time, such as bridge/panel.c.

Add devm_drm_put_bridge() to manually release a devm-obtained bridge in
such cases.

Signed-off-by: Luca Ceresoli <luca.ceresoli@...tlin.com>
---

To: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>
To: Maxime Ripard <mripard@...nel.org>
To: Thomas Zimmermann <tzimmermann@...e.de>
To: David Airlie <airlied@...il.com>
To: Simona Vetter <simona@...ll.ch>
To: Andrzej Hajda <andrzej.hajda@...el.com>
To: Neil Armstrong <neil.armstrong@...aro.org>
To: Robert Foss <rfoss@...nel.org>
To: Laurent Pinchart <Laurent.pinchart@...asonboard.com>
To: Jonas Karlman <jonas@...boo.se>
To: Jernej Skrabec <jernej.skrabec@...il.com>
To: Jagan Teki <jagan@...rulasolutions.com>
To: Shawn Guo <shawnguo@...nel.org>
To: Sascha Hauer <s.hauer@...gutronix.de>
To: Pengutronix Kernel Team <kernel@...gutronix.de>
To: Fabio Estevam <festevam@...il.com>
To: Douglas Anderson <dianders@...omium.org>
To: Chun-Kuang Hu <chunkuang.hu@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Anusha Srivatsa <asrivats@...hat.com>
Cc: Paul Kocialkowski <paulk@...-base.io>
Cc: Dmitry Baryshkov <lumag@...nel.org>
Cc: Hervé Codina <herve.codina@...tlin.com>
Cc: Hui Pu <Hui.Pu@...ealthcare.com>
Cc: Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Cc: dri-devel@...ts.freedesktop.org
Cc: asahi@...ts.linux.dev
Cc: linux-kernel@...r.kernel.org
Cc: chrome-platform@...ts.linux.dev
Cc: imx@...ts.linux.dev
Cc: linux-arm-kernel@...ts.infradead.org
Cc: linux-mediatek@...ts.infradead.org
Cc: linux-amlogic@...ts.infradead.org
Cc: linux-renesas-soc@...r.kernel.org
Cc: platform-driver-x86@...r.kernel.org
Cc: linux-samsung-soc@...r.kernel.org
Cc: linux-arm-msm@...r.kernel.org
Cc: freedreno@...ts.freedesktop.org
Cc: linux-stm32@...md-mailman.stormreply.com
---
 drivers/gpu/drm/drm_bridge.c | 14 ++++++++++++++
 include/drm/drm_bridge.h     |  4 ++++
 2 files changed, 18 insertions(+)

diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
index b4c89ec01998b849018ce031c7cd84614e65e710..456363d86080b2a55035c3108c16afa4f9e57e06 100644
--- a/drivers/gpu/drm/drm_bridge.c
+++ b/drivers/gpu/drm/drm_bridge.c
@@ -1392,6 +1392,20 @@ struct drm_bridge *of_drm_find_bridge(struct device_node *np)
 EXPORT_SYMBOL(of_drm_find_bridge);
 #endif
 
+/**
+ * devm_drm_put_bridge - Release a bridge reference obtained via devm
+ * @dev: device that got the bridge via devm
+ * @bridge: pointer to a struct drm_bridge obtained via devm
+ *
+ * Same as drm_bridge_put() for bridge pointers obtained via devm functions
+ * such as devm_drm_bridge_alloc().
+ */
+void devm_drm_put_bridge(struct device *dev, struct drm_bridge *bridge)
+{
+	devm_release_action(dev, drm_bridge_put_void, bridge);
+}
+EXPORT_SYMBOL(devm_drm_put_bridge);
+
 static void drm_bridge_debugfs_show_bridge(struct drm_printer *p,
 					   struct drm_bridge *bridge,
 					   unsigned int idx)
diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
index df9bbf6fd1fb522add28b76406b74cdb7391fc57..5b4e5e935a17ba6fc4a6a53ad0a302e249ca418b 100644
--- a/include/drm/drm_bridge.h
+++ b/include/drm/drm_bridge.h
@@ -1167,6 +1167,8 @@ static inline struct drm_bridge *devm_drm_of_get_bridge(struct device *dev,
 	return ERR_PTR(-ENODEV);
 }
 
+static inline void devm_drm_put_bridge(struct device *dev, struct drm_bridge *bridge) {}
+
 static inline struct drm_bridge *drmm_of_get_bridge(struct drm_device *drm,
 						     struct device_node *node,
 						     u32 port,
@@ -1176,6 +1178,8 @@ static inline struct drm_bridge *drmm_of_get_bridge(struct drm_device *drm,
 }
 #endif
 
+void devm_drm_put_bridge(struct device *dev, struct drm_bridge *bridge);
+
 void drm_bridge_debugfs_params(struct dentry *root);
 void drm_bridge_debugfs_encoder_params(struct dentry *root, struct drm_encoder *encoder);
 

-- 
2.49.0

Powered by blists - more mailing lists