linux-kernel - Re: [PATCH v6 3/4] tracing: Use vmap_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2c0b957b-3a7c-4607-9a8b-79fcbf7297c8@roeck-us.net>
Date: Mon, 7 Apr 2025 08:57:44 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 Linus Torvalds <torvalds@...ux-foundation.org>,
 Masami Hiramatsu <mhiramat@...nel.org>, Mark Rutland <mark.rutland@....com>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Vincent Donnefort <vdonnefort@...gle.com>, Vlastimil Babka <vbabka@...e.cz>,
 Mike Rapoport <rppt@...nel.org>, Jann Horn <jannh@...gle.com>
Subject: Re: [PATCH v6 3/4] tracing: Use vmap_page_range() to map memmap ring
 buffer

On 4/7/25 08:23, Steven Rostedt wrote:
> On Sun, 6 Apr 2025 10:39:27 -0700
> Guenter Roeck <linux@...ck-us.net> wrote:
> 
>> non-MMU builds (xtensa:nommu_kc705_defconfig):
> 
> Bah!
> 
:-)

>>
>> kernel/trace/trace.o:(.init.literal+0x250): undefined reference to `get_vm_area'
> 
> Does this fix it?
> 

Yes, it does.

Tested-by: Guenter Roeck <linux@...ck-us.net>

Thanks,
Guenter

> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index b581e388a9d9..8ddf6b17215c 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -9806,6 +9806,7 @@ static int instance_mkdir(const char *name)
>   	return ret;
>   }
>   
> +#ifdef CONFIG_MMU
>   static u64 map_pages(unsigned long start, unsigned long size)
>   {
>   	unsigned long vmap_start, vmap_end;
> @@ -9828,6 +9829,12 @@ static u64 map_pages(unsigned long start, unsigned long size)
>   
>   	return (u64)vmap_start;
>   }
> +#else
> +static inline u64 map_pages(unsigned long start, unsigned long size)
> +{
> +	return 0;
> +}
> +#endif
>   
>   /**
>    * trace_array_get_by_name - Create/Lookup a trace array, given its name.
> 
> 
> -- Steve