linux-kernel - Re: [PATCH net-next 10/12] afs: Use rxgk RESPONSE to pass token for callback channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250407161225.GQ395307@horms.kernel.org>
Date: Mon, 7 Apr 2025 17:12:25 +0100
From: Simon Horman <horms@...nel.org>
To: David Howells <dhowells@...hat.com>
Cc: netdev@...r.kernel.org, Marc Dionne <marc.dionne@...istor.com>,
	Jakub Kicinski <kuba@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Christian Brauner <brauner@...nel.org>,
	Chuck Lever <chuck.lever@...cle.com>, linux-afs@...ts.infradead.org,
	openafs-devel@...nafs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 10/12] afs: Use rxgk RESPONSE to pass token for
 callback channel

On Mon, Apr 07, 2025 at 10:14:41AM +0100, David Howells wrote:
> Implement in kafs the hook for adding appdata into a RESPONSE packet
> generated in response to an RxGK CHALLENGE packet, and include the key for
> securing the callback channel so that notifications from the fileserver get
> encrypted.
> 
> This will be necessary when more complex notifications are used that convey
> changed data around.
> 
> Signed-off-by: David Howells <dhowells@...hat.com>

...

> diff --git a/fs/afs/cm_security.c b/fs/afs/cm_security.c

...

> +/*
> + * Create an YFS RxGK GSS token to use as a ticket to the specified fileserver.
> + */
> +static int afs_create_yfs_cm_token(struct sk_buff *challenge,
> +				   struct afs_server *server)
> +{

...

> +	if ((unsigned long)xdr - (unsigned long)appdata != adatasize)
> +		pr_err("Appdata size incorrect %zx != %zx\n",
> +		       (unsigned long)xdr - (unsigned long)appdata, adatasize);

Hi David,

x86_32 allmodconfig W=1 builds complain that:

warning: format ‘%zx’ expects argument of type ‘size_t’, but argument 2 has type ‘long unsigned int’ [-Wformat=]

...