linux-kernel - Re: [PATCH] EISA: Increase length of device names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202504070948.B71965DC7@keescook>
Date: Mon, 7 Apr 2025 09:49:04 -0700
From: Kees Cook <kees@...nel.org>
To: Alex Elder <elder@...cstar.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Azeem Shaikh <azeemshaikh38@...il.com>,
	Alex Elder <elder@...nel.org>, Sumit Garg <sumit.garg@...nel.org>,
	linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org,
	alx@...nel.org
Subject: Re: [PATCH] EISA: Increase length of device names

On Sat, Mar 15, 2025 at 09:27:36AM -0500, Alex Elder wrote:
> On 3/10/25 5:24 PM, Kees Cook wrote:
> > GCC 15's -Wunterminated-string-initialization warned about truncated
> > name strings. Instead of marking them with the "nonstring" attribute[1],
> > increase their length to correctly include enough space for the
> > terminating NUL character, as they are used with %s format specifiers.
> > 
> > Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117178 [1]
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Cc: Azeem Shaikh <azeemshaikh38@...il.com>
> > Cc: Alex Elder <elder@...nel.org>
> 
> This was interesting, but based on the bug text I suspect you
> meant to address this to Alejandro Colomar, <alx@...nel.org>.

I think you got tagged because of the Reviewed-by on commit d69d80484598
("driver core: have match() callback in struct bus_type take a const *")
which touched include/linux/eisa.h.

> For what it's worth, it looks fine to me.

Thanks!

-- 
Kees Cook