linux-kernel - RE: [PATCH 1/4] extcon: adc-jack: Fix wakeup source leaks on device unbind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250407045832epcms1p7956a6ce5af6d2f8cca6169a68fd7bf31@epcms1p7>
Date: Mon, 07 Apr 2025 13:58:32 +0900
From: MyungJoo Ham <myungjoo.ham@...sung.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Chanwoo Choi
	<cw00.choi@...sung.com>, Hans de Goede <hdegoede@...hat.com>, Chen-Yu Tsai
	<wens@...e.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>
Subject: RE: [PATCH 1/4] extcon: adc-jack: Fix wakeup source leaks on device
 unbind

>Device can be unbound, so driver must also release memory for the wakeup
>source.
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>---
> drivers/extcon/extcon-adc-jack.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/extcon/extcon-adc-jack.c b/drivers/extcon/extcon-adc-jack.c
>index 46c40d85c2ac89599ffbe7b6d11b161b295d5564..d7e4b1418d7e6b242780b3511f2a49def3acb7a6 100644
>--- a/drivers/extcon/extcon-adc-jack.c
>+++ b/drivers/extcon/extcon-adc-jack.c
>@@ -164,6 +164,7 @@ static void adc_jack_remove(struct platform_device *pdev)
> {
> 	struct adc_jack_data *data = platform_get_drvdata(pdev);
> 
>+	device_init_wakeup(&pdev->dev, 0);
> 	free_irq(data->irq, data);
> 	cancel_work_sync(&data->handler.work);
> }

Acked-by: MyungJoo Ham <myungjoo.ham@...sung.com>


Cheers,
MyungJoo