[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Z_QO8QybPCwzRwms@gmail.com>
Date: Mon, 7 Apr 2025 19:44:17 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Ard Biesheuvel <ardb+git@...gle.com>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org, linux-efi@...r.kernel.org,
Ard Biesheuvel <ardb@...nel.org>
Subject: Re: [PATCH v2 1/2] x86/boot: Move early kernel mapping code into
startup/
* Ard Biesheuvel <ardb+git@...gle.com> wrote:
> From: Ard Biesheuvel <ardb@...nel.org>
>
> The startup code that constructs the kernel virtual mapping runs from
> the 1:1 mapping of memory itself, and therefore, cannot use absolute
> symbol references. Move this code into a separate source file under
> arch/x86/boot/startup/ where all such code will be kept from now on.
>
> Since all code here is constructed in a manner that ensures that it
> tolerates running from the 1:1 mapping of memory, any uses of the
> RIP_REL_REF() macro can be dropped, along with __head annotations for
> placing this code in a dedicated startup section.
So would it be possible to do this in ~3 steps: first the mechanic
movement of code, with very few changes (if the result builds & boots),
then drop the RIP_REL_REF() uses and __head annotations in two separate
patches?
Bisectability, ease of review, etc.
(The tiny bird gets the worm, but I might have butchered that proverb.)
Thanks,
Ingo
Powered by blists - more mailing lists