linux-kernel - Re: [PATCH] crypto: tegra: Fix IV usage for AES ECB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z_NgqqGqFtgF5xgT@gondor.apana.org.au>
Date: Mon, 7 Apr 2025 13:20:42 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Akhil R <akhilrajeev@...dia.com>
Cc: davem@...emloft.net, thierry.reding@...il.com, jonathanh@...dia.com,
	linux-crypto@...r.kernel.org, linux-tegra@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: tegra: Fix IV usage for AES ECB

On Wed, Mar 26, 2025 at 08:21:10PM +0530, Akhil R wrote:
> Modifying the crypto_request turns out to be not the right way to handle
> the stale value issue with the IV. Though the IV is not used for AES ECB,
> it eventually get used in algorithms like LRW in the next step after
> AES ECB encryption/decryption. Setting req->iv to NULL breaks the
> implementation of such algorithms. Hence modify only the local reqctx
> to check for IV.
> 
> Fixes: bde558220866 ("crypto: tegra - Set IV to NULL explicitly for AES ECB")
> Signed-off-by: Akhil R <akhilrajeev@...dia.com>
> ---
>  drivers/crypto/tegra/tegra-se-aes.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt