linux-kernel - Re: [PATCH] regulator: hi6421v600: Truncate long strings for trailing NUL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202504071134.1AAF30CAF5@keescook>
Date: Mon, 7 Apr 2025 11:35:33 -0700
From: Kees Cook <kees@...nel.org>
To: Liam Girdwood <lgirdwood@...il.com>
Cc: Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org,
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH] regulator: hi6421v600: Truncate long strings for
 trailing NUL

On Mon, Mar 10, 2025 at 03:24:09PM -0700, Kees Cook wrote:
> GCC 15's -Wunterminated-string-initialization saw that these strings
> were being truncated. Adjust the initializer so that the needed final
> NUL character will be present.
> 
> Cc: Liam Girdwood <lgirdwood@...il.com>
> Cc: Mark Brown <broonie@...nel.org>
> Signed-off-by: Kees Cook <kees@...nel.org>
> ---
>  drivers/regulator/hi6421v600-regulator.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/regulator/hi6421v600-regulator.c b/drivers/regulator/hi6421v600-regulator.c
> index e5f6fbfc9016..e74f992fd85f 100644
> --- a/drivers/regulator/hi6421v600-regulator.c
> +++ b/drivers/regulator/hi6421v600-regulator.c
> @@ -275,7 +275,7 @@ static int hi6421_spmi_regulator_probe(struct platform_device *pdev)
>  }
>  
>  static const struct platform_device_id hi6421_spmi_regulator_table[] = {
> -	{ .name = "hi6421v600-regulator" },
> +	{ .name = "hi6421v600-regulato" },
>  	{},
>  };
>  MODULE_DEVICE_TABLE(platform, hi6421_spmi_regulator_table);
> @@ -283,7 +283,7 @@ MODULE_DEVICE_TABLE(platform, hi6421_spmi_regulator_table);
>  static struct platform_driver hi6421_spmi_regulator_driver = {
>  	.id_table = hi6421_spmi_regulator_table,
>  	.driver = {
> -		.name = "hi6421v600-regulator",
> +		.name = "hi6421v600-regulato",
>  		.probe_type = PROBE_PREFER_ASYNCHRONOUS,
>  	},
>  	.probe	= hi6421_spmi_regulator_probe,

Friendly ping on this patch. Who can pick this up?

Thanks!

-Kees

-- 
Kees Cook