linux-kernel - Re: [PATCH v1 1/1] device property: Add a note to the fwnode.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hFNqUTVn4wVqigzhHTnmPU63+Z8iFwv++=gx8P7A-cow@mail.gmail.com>
Date: Mon, 7 Apr 2025 20:44:20 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Zijun Hu <quic_zijuhu@...cinc.com>, 
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Len Brown <lenb@...nel.org>, Daniel Scally <djrscally@...il.com>, 
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>, 
	Sakari Ailus <sakari.ailus@...ux.intel.com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Danilo Krummrich <dakr@...nel.org>, 
	Laurent Pinchart <laurent.pinchart@...asonboard.com>
Subject: Re: [PATCH v1 1/1] device property: Add a note to the fwnode.h

On Mon, Apr 7, 2025 at 8:36 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> On Mon, Apr 07, 2025 at 08:17:17PM +0200, Rafael J. Wysocki wrote:
> > On Mon, Mar 31, 2025 at 6:32 PM Andy Shevchenko
> > <andriy.shevchenko@...ux.intel.com> wrote:
> > >
> > > Add a note to the fwnode.h that the header should not be used
> > > directly in the leaf drivers, they all should use the higher
> > > level APIs and the respective headers.
> >
> > This sounds like a solution to a problem, but the problem statement is missing.
>
> > What's your motivation?
>
> Found a few drivers that are mistakenly include fwnode.h while they meant to
> have either of.h or more likely property.h.

I see.

I would then say

"This header file provides low-level data types and definitions for
firmware and device property providers.  The respective API header
files supplied by them should contain all of the requisite data types
and definitions for end users, so including it directly should not be
necessary."

And I would mention that the purpose is to give guidance to driver
writers to avoid repeating a common mistake.

>
> ...
>
> > > + * Note, this header is not meant to be used by the leaf drivers.
> > > + * It provides the low level data types and definitions for the firmware
> > > + * and device property providers. The respective API headers should
> > > + * guarantee all the required data types and definitions without including
> > > + * this header directly.
>
> --