linux-kernel - Re: [GIT PULL] string fixes for v6.15-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wi89ogViEN5oTBmcNQXnMEB5_Qse9G401pSNzocP_dqQQ@mail.gmail.com>
Date: Mon, 7 Apr 2025 12:02:04 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Nathan Chancellor <nathan@...nel.org>
Cc: Kees Cook <kees@...nel.org>, linux-kernel@...r.kernel.org, 
	Andrey Konovalov <andreyknvl@...il.com>, Andy Shevchenko <andy@...nel.org>, 
	Catalin Marinas <catalin.marinas@....com>, Peter Collingbourne <pcc@...gle.com>, 
	Vincenzo Frascino <vincenzo.frascino@....com>, Will Deacon <will@...nel.org>, llvm@...ts.linux.dev
Subject: Re: [GIT PULL] string fixes for v6.15-rc1

On Mon, 7 Apr 2025 at 10:37, Nathan Chancellor <nathan@...nel.org> wrote:
>
> So would the following change be acceptable? I can draft up a commit
> message and send it along today if so.

Absoluterly. That's the right thing to do.

> +# Ensure clang does not transform certain loops into calls to wcslen() after
> +# https://github.com/llvm/llvm-project/commit/9694844d7e36fd5e01011ab56b64f27b867aa72d
> +KBUILD_CFLAGS-$(call clang-min-version, 210000) += -fno-builtin-wcslen

I think you could just use

     KBUILD_CFLAGS += $(call cc-option, -fno-builtin-wcslen)

instead, and not use some version check?

          Linus