linux-kernel - Re: [PATCH 0/7] iio: convert GPIO chips to using new value setters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250407201607.27257aa2@jic23-huawei>
Date: Mon, 7 Apr 2025 20:16:07 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich
 <Michael.Hennerich@...log.com>, Linus Walleij <linus.walleij@...aro.org>,
 Cosmin Tanislav <cosmin.tanislav@...log.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org, Bartosz
 Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 0/7] iio: convert GPIO chips to using new value setters

On Mon, 07 Apr 2025 09:18:08 +0200
Bartosz Golaszewski <brgl@...ev.pl> wrote:

> struct gpio_chip now has callbacks for setting line values that return
> an integer, allowing to indicate failures. We're in the process of
> converting all GPIO drivers to using the new API. This series converts
> all the IIO GPIO controllers and also contains some additional
> refactoring patches for ad5592r in preparation for the conversion.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Nice.  All the _rv patches look good to me. Just a few minor things
on the precursors.  One other driver crossed with this, but Matti has
posted a patch updating that one as well.

https://lore.kernel.org/all/Z_N_J52IZ2IaWawl@mva-rohm/

Thanks,

Jonathan

> ---
> Bartosz Golaszewski (7):
>       iio: dac: ad5592r: destroy mutexes in detach paths
>       iio: dac: ad5592r: use lock guards
>       iio: dac: ad5592r: use new GPIO line value setter callbacks
>       iio: adc: ti-ads7950: use new GPIO line value setter callbacks
>       iio: adc: ad4130: use new GPIO line value setter callbacks
>       iio: addac: ad74413r: use new GPIO line value setter callbacks
>       iio: addac: ad74115: use new GPIO line value setter callbacks
> 
>  drivers/iio/adc/ad4130.c       |  10 ++--
>  drivers/iio/adc/ti-ads7950.c   |  17 ++++--
>  drivers/iio/addac/ad74115.c    |  18 +++---
>  drivers/iio/addac/ad74413r.c   |  28 ++++-----
>  drivers/iio/dac/ad5592r-base.c | 132 +++++++++++++++++------------------------
>  5 files changed, 95 insertions(+), 110 deletions(-)
> ---
> base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
> change-id: 20250401-gpiochip-set-rv-iio-b064ce43791d
> 
> Best regards,